* [PATCH] ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler()
@ 2009-10-13 21:55 H Hartley Sweeten
2009-10-21 1:00 ` Ryan Mallon
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-10-13 21:55 UTC (permalink / raw)
To: linux-arm-kernel
Remove unnecessary code in ep93xx_gpio_ab_irq_handler().
The desc calculation for gpio port B was left in when the following
commit was merged.
commit d8aa0251f12546e9bd1e9ee1d9782d6492819a04
Author: Dmitry Baryshkov <dbaryshkov@gmail.com>
Date: Thu Oct 9 13:36:24 2008 +0100
[ARM] 5298/1: Drop desc_handle_irq()
It's not needed so remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>
---
diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
index f95dc16..b4357c3 100644
--- a/arch/arm/mach-ep93xx/core.c
+++ b/arch/arm/mach-ep93xx/core.c
@@ -206,7 +206,6 @@ static void ep93xx_gpio_ab_irq_handler(unsigned int irq, struct irq_desc *desc)
for (i = 0; i < 8; i++) {
if (status & (1 << i)) {
int gpio_irq = gpio_to_irq(EP93XX_GPIO_LINE_B(0)) + i;
- desc = irq_desc + gpio_irq;
generic_handle_irq(gpio_irq);
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler()
2009-10-13 21:55 [PATCH] ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler() H Hartley Sweeten
@ 2009-10-21 1:00 ` Ryan Mallon
0 siblings, 0 replies; 2+ messages in thread
From: Ryan Mallon @ 2009-10-21 1:00 UTC (permalink / raw)
To: linux-arm-kernel
H Hartley Sweeten wrote:
> Remove unnecessary code in ep93xx_gpio_ab_irq_handler().
>
> The desc calculation for gpio port B was left in when the following
> commit was merged.
>
> commit d8aa0251f12546e9bd1e9ee1d9782d6492819a04
> Author: Dmitry Baryshkov <dbaryshkov@gmail.com>
> Date: Thu Oct 9 13:36:24 2008 +0100
>
> [ARM] 5298/1: Drop desc_handle_irq()
>
> It's not needed so remove it.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
>
> ---
>
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index f95dc16..b4357c3 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -206,7 +206,6 @@ static void ep93xx_gpio_ab_irq_handler(unsigned int irq, struct irq_desc *desc)
> for (i = 0; i < 8; i++) {
> if (status & (1 << i)) {
> int gpio_irq = gpio_to_irq(EP93XX_GPIO_LINE_B(0)) + i;
> - desc = irq_desc + gpio_irq;
> generic_handle_irq(gpio_irq);
> }
> }
>
Acked-by: Ryan Mallon <ryan@bluewatersys.com>
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-21 1:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-13 21:55 [PATCH] ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler() H Hartley Sweeten
2009-10-21 1:00 ` Ryan Mallon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).