From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] em-x270: don't use pxa_camera init() callback
Date: Wed, 18 Nov 2009 08:34:30 +0200 [thread overview]
Message-ID: <4B039576.3020105@compulab.co.il> (raw)
In-Reply-To: <1258495463-26029-2-git-send-email-ospite@studenti.unina.it>
Antonio Ospite wrote:
> pxa_camera init() is going to be removed.
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> ---
> arch/arm/mach-pxa/em-x270.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
Acked-by: Mike Rapoport <mike@compulab.co.il>
> diff --git a/arch/arm/mach-pxa/em-x270.c b/arch/arm/mach-pxa/em-x270.c
> index aec7f42..f71f34c 100644
> --- a/arch/arm/mach-pxa/em-x270.c
> +++ b/arch/arm/mach-pxa/em-x270.c
> @@ -967,7 +967,7 @@ static inline void em_x270_init_gpio_keys(void) {}
> #if defined(CONFIG_VIDEO_PXA27x) || defined(CONFIG_VIDEO_PXA27x_MODULE)
> static struct regulator *em_x270_camera_ldo;
>
> -static int em_x270_sensor_init(struct device *dev)
> +static int em_x270_sensor_init(void)
> {
> int ret;
>
> @@ -996,7 +996,6 @@ static int em_x270_sensor_init(struct device *dev)
> }
>
> struct pxacamera_platform_data em_x270_camera_platform_data = {
> - .init = em_x270_sensor_init,
> .flags = PXA_CAMERA_MASTER | PXA_CAMERA_DATAWIDTH_8 |
> PXA_CAMERA_PCLK_EN | PXA_CAMERA_MCLK_EN,
> .mclk_10khz = 2600,
> @@ -1049,8 +1048,10 @@ static struct platform_device em_x270_camera = {
>
> static void __init em_x270_init_camera(void)
> {
> - pxa_set_camera_info(&em_x270_camera_platform_data);
> - platform_device_register(&em_x270_camera);
> + if (em_x270_sensor_init() == 0) {
> + pxa_set_camera_info(&em_x270_camera_platform_data);
> + platform_device_register(&em_x270_camera);
> + }
> }
> #else
> static inline void em_x270_init_camera(void) {}
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2009-11-18 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:04 [PATCH 0/3] pxa_camera: remove init() callback Antonio Ospite
2009-11-17 22:04 ` [PATCH 1/3] em-x270: don't use pxa_camera " Antonio Ospite
2009-11-18 6:34 ` Mike Rapoport [this message]
2009-11-18 10:10 ` Guennadi Liakhovetski
2009-11-18 17:02 ` Antonio Ospite
2009-11-27 20:30 ` [PATCH 1/3 v2] " Antonio Ospite
2009-11-17 22:04 ` [PATCH 2/3] pcm990-baseboard: " Antonio Ospite
2009-11-18 10:12 ` Guennadi Liakhovetski
2009-11-18 10:39 ` Juergen Beisert
2009-11-27 20:31 ` [PATCH 2/3 v2] " Antonio Ospite
2009-11-29 2:29 ` Eric Miao
2009-11-17 22:04 ` [PATCH 3/3] pxa_camera: remove " Antonio Ospite
2009-11-27 14:06 ` Guennadi Liakhovetski
2009-11-27 14:32 ` Antonio Ospite
2009-11-27 14:37 ` Guennadi Liakhovetski
2009-11-27 14:47 ` Antonio Ospite
2009-11-27 20:39 ` [PATCH 0/3] " Antonio Ospite
2009-11-29 2:25 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B039576.3020105@compulab.co.il \
--to=mike@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).