From: bahadir@l4dev.org (Bahadir Balban)
To: linux-arm-kernel@lists.infradead.org
Subject: Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range
Date: Fri, 18 Dec 2009 14:54:37 +0200 [thread overview]
Message-ID: <4B2B7B8D.9030403@l4dev.org> (raw)
Hi,
You don't seem to be testing for VM_EXEC as in v6 version, so
vma_vm_flags seem redundant. What do you think?
---
arch/arm/mm/tlb-v7.S | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/tlb-v7.S b/arch/arm/mm/tlb-v7.S
index a26a605..0cb1848 100644
--- a/arch/arm/mm/tlb-v7.S
+++ b/arch/arm/mm/tlb-v7.S
@@ -40,7 +40,6 @@ ENTRY(v7wbi_flush_user_tlb_range)
asid r3, r3 @ mask ASID
orr r0, r3, r0, lsl #PAGE_SHIFT @ Create initial MVA
mov r1, r1, lsl #PAGE_SHIFT
- vma_vm_flags r2, r2 @ get vma->vm_flags
1:
#ifdef CONFIG_SMP
mcr p15, 0, r0, c8, c3, 1 @ TLB invalidate U MVA (shareable)
--
1.5.4.3
--
Bahadir Balban
next reply other threads:[~2009-12-18 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 12:54 Bahadir Balban [this message]
2009-12-22 15:27 ` Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2B7B8D.9030403@l4dev.org \
--to=bahadir@l4dev.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).