* Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range
@ 2009-12-18 12:54 Bahadir Balban
2009-12-22 15:27 ` Russell King - ARM Linux
0 siblings, 1 reply; 2+ messages in thread
From: Bahadir Balban @ 2009-12-18 12:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
You don't seem to be testing for VM_EXEC as in v6 version, so
vma_vm_flags seem redundant. What do you think?
---
arch/arm/mm/tlb-v7.S | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/tlb-v7.S b/arch/arm/mm/tlb-v7.S
index a26a605..0cb1848 100644
--- a/arch/arm/mm/tlb-v7.S
+++ b/arch/arm/mm/tlb-v7.S
@@ -40,7 +40,6 @@ ENTRY(v7wbi_flush_user_tlb_range)
asid r3, r3 @ mask ASID
orr r0, r3, r0, lsl #PAGE_SHIFT @ Create initial MVA
mov r1, r1, lsl #PAGE_SHIFT
- vma_vm_flags r2, r2 @ get vma->vm_flags
1:
#ifdef CONFIG_SMP
mcr p15, 0, r0, c8, c3, 1 @ TLB invalidate U MVA (shareable)
--
1.5.4.3
--
Bahadir Balban
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range
2009-12-18 12:54 Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range Bahadir Balban
@ 2009-12-22 15:27 ` Russell King - ARM Linux
0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2009-12-22 15:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2009 at 02:54:37PM +0200, Bahadir Balban wrote:
> Hi,
>
> You don't seem to be testing for VM_EXEC as in v6 version, so
> vma_vm_flags seem redundant. What do you think?
With a properly signed off patch, it could go to the patch system.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-22 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-18 12:54 Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range Bahadir Balban
2009-12-22 15:27 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).