From: richardliu@ms1.techarea.org (Richard Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI Domains Support
Date: Sat, 26 Dec 2009 05:58:05 +0800 [thread overview]
Message-ID: <4B35356D.7090604@ms1.techarea.org> (raw)
In-Reply-To: <20091222045540.GB4411@verge.net.au>
Simon Horman wrote:
>> Actually, most ARM platforms didn't need PCI domains.
>>
>> So, original patch is
>>
>> +config PCI_DOMAINS
>> + def_bool y
>> + depends on PCI && ARCH_CXXXXXX
>> +
>>
>> But I removed the "&& ARCH_CXXXXXXX" before I provided the patch.
>> Because ARCH_CXXXXXXX is not exist in ARM Linux kernel now (maybe it
>> would be committed at someday)
>>
>
> Ok, now I am completely confused. Nothing currently in-tree should
> use PCI_DOMAINS, but it defaults to y and nothing switches it to n?
>
> Perhaps the following would be more appropriate:
>
> config PCI_DOMAINS
> bool
>
> And then platforms can "select PCI_DOMAINS" as needed.
>
>
You are right,
Don't use def_bool is right choice.
I only maintain one arch, so I didn't think too much.
Should I regenerate a new patch, or you will handle it ?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091226/b630705f/attachment-0001.htm>
next prev parent reply other threads:[~2009-12-25 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 14:13 [Fwd: [PATCH] PCI Domains Support] Richard Liu
2009-12-17 0:06 ` Simon Horman
2009-12-17 13:01 ` [PATCH] PCI Domains Support Richard Liu
2009-12-20 1:27 ` Simon Horman
2009-12-21 6:00 ` Richard Liu
2009-12-22 4:55 ` Simon Horman
2009-12-25 21:58 ` Richard Liu [this message]
2009-12-23 4:07 ` Simon Horman
2009-12-31 3:37 ` Richard Liu
2009-12-31 4:36 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B35356D.7090604@ms1.techarea.org \
--to=richardliu@ms1.techarea.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).