From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFD0CC47073 for ; Tue, 2 Jan 2024 06:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xdsUThIe2bwnWGT/n4M/BXQyICaXRZhwByAb1Pu3RWA=; b=Zb9nNHyiHxpvpq T7HgiGLJ/ws4JJiNX7vApDVpmBPFEeU1lqQfRPXau2wbLz6d0gof0sYAzfY3ElhVzyHjLSPwEVsOY Ox2Cff7p9D75CTVsJCZQ2TYwAAF3tV7UAdU5+qKdPhFJ/8gOEP7TskSORzcoQdGvVFT2sEpAtGpS5 MTofgfDblhWcvSVo2vjwmtZPCugn8RafOCKejYm08mt5tZmU4c1RcE4+A7hEw8Yg2trwszxOrs5eB 2sdIzdnhepEglJwFglfOakMjZ3+cIrVnxCf0cxKVyU7EmF5byV986UkRXZBlV9ws/Hh0Gjmm//EnP arJhFAI3znBxTyGb+1pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKYIt-007B8G-1P; Tue, 02 Jan 2024 06:31:07 +0000 Received: from out-172.mta0.migadu.com ([2001:41d0:1004:224b::ac]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKYIn-007B5y-2y for linux-arm-kernel@lists.infradead.org; Tue, 02 Jan 2024 06:31:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704177059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwM83SlsLb1lbvo4JCqZZv0h8wT6KPgcWS/HAwN04/0=; b=o38+Omrur7cm8Q/e0nLnXqBIsWvLMDkbm5ptAnn/ZlZWQiCVmcDjZtwoEs60A94RgcAauv E132opwWBTvCsPeDzfzlh9A4yzPTIVTPtHNC/5L0+b6GA84IBDoYN0L7I27E5LuYL9UL8A OyzbfsSDRORVadxA5D4C39d8zPUzD98= Mime-Version: 1.0 Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 2 Jan 2024 14:30:25 +0800 Cc: LKML , Linux-MM , Matthew Wilcox , Christophe Leroy , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Mike Kravetz , Mike Rapoport , Christoph Hellwig , John Hubbard , Andrew Jones , linux-arm-kernel@lists.infradead.org, Michael Ellerman , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Rik van Riel , linux-riscv@lists.infradead.org, Yang Shi , James Houghton , "Aneesh Kumar K . V" , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli , Axel Rasmussen Message-Id: <4B38660D-3AC2-4F96-9DD1-2D8CAA55E7E4@linux.dev> References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> To: Peter Xu X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_223102_097919_A65B90D1 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Jan 2, 2024, at 13:37, Peter Xu wrote: > > On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: >>> @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) >>> #endif /* pmd_write */ >>> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >>> +#ifndef pmd_thp_or_huge >> >> I think it may be the time to rename to pmd_thp_or_hugetlb, >> the "huge" is really confusing. thp is not huge? Actually, >> it is huge. It is better to make it more specific from now on, like >> "hugetlb". > > The rename will need to touch ARM code, which I wanted to avoid, see: I see. > > arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) > > So far this series only touches generic code. Would you mind I keep this > patch as-is, and leave renaming to later? OK. THanks. > >> >> BTW, please cc me via the new email (muchun.song@linux.dev) next edition. > > Sure. Thanks for taking a look. > > -- > Peter Xu > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel