[PATCH] NUC900: Add extern header file support for some driver

[PATCH] NUC900: Add extern header file support for some driver

[Wan ZongShun]

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you
want to use those APIs, please include corresponding header file.

Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
 arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
 arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h

diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h
b/arch/arm/mach-w90x900/include/mach/clkdev.h
index 04b37a8..b35f4bc 100644
--- a/arch/arm/mach-w90x900/include/mach/clkdev.h
+++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
@@ -4,4 +4,7 @@
 #define __clk_get(clk) ({ 1; })
 #define __clk_put(clk) do { } while (0)

+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
*src,
+							unsigned char divider);
+
 #endif
diff --git a/arch/arm/mach-w90x900/include/mach/mfp.h
b/arch/arm/mach-w90x900/include/mach/mfp.h
new file mode 100644
index 0000000..69a094a
--- /dev/null
+++ b/arch/arm/mach-w90x900/include/mach/mfp.h
@@ -0,0 +1,23 @@
+/*
+ * arch/arm/mach-w90x900/include/mach/mfp.h
+ *
+ * Copyright (c) 2008 Nuvoton technology corporation
+ * All rights reserved.
+ *
+ * Wan ZongShun <mcuos.com@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ */
+#ifndef __ASM_ARM_MFP_H
+#define __ASM_ARM_MFP_H
+
+extern void mfp_set_groupf(struct device *dev);
+extern void mfp_set_groupc(struct device *dev);
+extern void mfp_set_groupi(struct device *dev);
+extern void mfp_set_groupg(struct device *dev);
+
+#endif /* __ASM_ARM_MFP_H */
-- 
1.5.6.3

[PATCH] NUC900: Add extern header file support for some driver

[Wan ZongShun]

Dear  Sergei,

You are right, and it reason from my mail client setting.
Re-submit it.

Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
  arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
  arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
  2 files changed, 26 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h

diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h 
b/arch/arm/mach-w90x900/include/mach/clkdev.h
index 04b37a8..b35f4bc 100644
--- a/arch/arm/mach-w90x900/include/mach/clkdev.h
+++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
@@ -4,4 +4,7 @@
  #define __clk_get(clk) ({ 1; })
  #define __clk_put(clk) do { } while (0)

+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char *src,
+							unsigned char divider);
+
  #endif
diff --git a/arch/arm/mach-w90x900/include/mach/mfp.h 
b/arch/arm/mach-w90x900/include/mach/mfp.h
new file mode 100644
index 0000000..69a094a
--- /dev/null
+++ b/arch/arm/mach-w90x900/include/mach/mfp.h
@@ -0,0 +1,23 @@
+/*
+ * arch/arm/mach-w90x900/include/mach/mfp.h
+ *
+ * Copyright (c) 2008 Nuvoton technology corporation
+ * All rights reserved.
+ *
+ * Wan ZongShun <mcuos.com@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ */
+#ifndef __ASM_ARM_MFP_H
+#define __ASM_ARM_MFP_H
+
+extern void mfp_set_groupf(struct device *dev);
+extern void mfp_set_groupc(struct device *dev);
+extern void mfp_set_groupi(struct device *dev);
+extern void mfp_set_groupg(struct device *dev);
+
+#endif /* __ASM_ARM_MFP_H */
-- 
1.5.6.3

[PATCH] NUC900: Add extern header file support for some driver

[Ben Dooks]

Wan ZongShun wrote:
> Dear Wang Qiang,
> 
> This patch provides a API for your LCD driver or other drivers, if you
> want to use those APIs, please include corresponding header file.
> 
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> ---
>  arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
>  arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
> 
> diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h
> b/arch/arm/mach-w90x900/include/mach/clkdev.h
> index 04b37a8..b35f4bc 100644
> --- a/arch/arm/mach-w90x900/include/mach/clkdev.h
> +++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
> @@ -4,4 +4,7 @@
>  #define __clk_get(clk) ({ 1; })
>  #define __clk_put(clk) do { } while (0)
> 
> +extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
> *src,
> +							unsigned char divider);
> +

hmm, why not have a 'struct clk' with a .set_rate method?

[PATCH] NUC900: Add extern header file support for some driver

[Russell King - ARM Linux]

On Sat, Jan 02, 2010 at 11:44:45PM +0800, Wan ZongShun wrote:
> Dear Wang Qiang,
> 
> This patch provides a API for your LCD driver or other drivers, if you
> want to use those APIs, please include corresponding header file.
> 
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> ---
>  arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
>  arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
> 
> diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h
> b/arch/arm/mach-w90x900/include/mach/clkdev.h
> index 04b37a8..b35f4bc 100644
> --- a/arch/arm/mach-w90x900/include/mach/clkdev.h
> +++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
> @@ -4,4 +4,7 @@
>  #define __clk_get(clk) ({ 1; })
>  #define __clk_put(clk) do { } while (0)
> 
> +extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
> *src,
> +							unsigned char divider);
> +

I'd prefer it if this header didn't get used for non-clkdev<->plat code
stuff.

[PATCH] NUC900: Add extern header file support for some driver

[王强]

2010/1/5 Russell King - ARM Linux <linux@arm.linux.org.uk>

> On Sat, Jan 02, 2010 at 11:44:45PM +0800, Wan ZongShun wrote:
> > Dear Wang Qiang,
> >
> > This patch provides a API for your LCD driver or other drivers, if you
> > want to use those APIs, please include corresponding header file.
> >
> > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> > ---
> >  arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
> >  arch/arm/mach-w90x900/include/mach/mfp.h    |   23
> +++++++++++++++++++++++
> >  2 files changed, 26 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
> >
> > diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h
> > b/arch/arm/mach-w90x900/include/mach/clkdev.h
> > index 04b37a8..b35f4bc 100644
> > --- a/arch/arm/mach-w90x900/include/mach/clkdev.h
> > +++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
> > @@ -4,4 +4,7 @@
> >  #define __clk_get(clk) ({ 1; })
> >  #define __clk_put(clk) do { } while (0)
> >
> > +extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
> > *src,
> > +                                                     unsigned char
> divider);
> > +
>
> I'd prefer it if this header didn't get used for non-clkdev<->plat code
> stuff.


So, you mean I can use this header in the LCD driver of nuc900 plat?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100105/90efb3e7/attachment-0001.htm>

[PATCH] NUC900: Add extern header file support for some driver

[Wan ZongShun]

2010/1/5 ?? <rurality.linux@gmail.com>:
>
>
> 2010/1/5 Russell King - ARM Linux <linux@arm.linux.org.uk>
>>
>> On Sat, Jan 02, 2010 at 11:44:45PM +0800, Wan ZongShun wrote:
>> > Dear Wang Qiang,
>> >
>> > This patch provides a API for your LCD driver or other drivers, if you
>> > want to use those APIs, please include corresponding header file.
>> >
>> > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
>> > ---
>> > ?arch/arm/mach-w90x900/include/mach/clkdev.h | ? ?3 +++
>> > ?arch/arm/mach-w90x900/include/mach/mfp.h ? ?| ? 23
>> > +++++++++++++++++++++++
>> > ?2 files changed, 26 insertions(+), 0 deletions(-)
>> > ?create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
>> >
>> > diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h
>> > b/arch/arm/mach-w90x900/include/mach/clkdev.h
>> > index 04b37a8..b35f4bc 100644
>> > --- a/arch/arm/mach-w90x900/include/mach/clkdev.h
>> > +++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
>> > @@ -4,4 +4,7 @@
>> > ?#define __clk_get(clk) ({ 1; })
>> > ?#define __clk_put(clk) do { } while (0)
>> >
>> > +extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
>> > *src,
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? unsigned char
>> > divider);
>> > +
>>
>> I'd prefer it if this header didn't get used for non-clkdev<->plat code
>> stuff.
>
> So, you mean I can use this header in the LCD driver of?nuc900 plat?
>

Hmmm, I don't think so.

I think it is better to implement other API as Ben Dooks mentioned,
but if you want to use
this API provided by me, we have to add the extern to other header
file rather than the specific clkdev header file.

So, please wait me for new patch.

-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com

[PATCH] NUC900: Add extern header file support for some driver

[Wang Qiang]

On Tue, Jan 5, 2010 at 11:43 AM, Wan ZongShun <mcuos.com@gmail.com> wrote:

> 2010/1/5 ?? <rurality.linux@gmail.com>:
> >
> >
> > 2010/1/5 Russell King - ARM Linux <linux@arm.linux.org.uk>
> >>
> >> On Sat, Jan 02, 2010 at 11:44:45PM +0800, Wan ZongShun wrote:
> >> > Dear Wang Qiang,
> >> >
> >> > This patch provides a API for your LCD driver or other drivers, if you
> >> > want to use those APIs, please include corresponding header file.
> >> >
> >> > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> >> > ---
> >> >  arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
> >> >  arch/arm/mach-w90x900/include/mach/mfp.h    |   23
> >> > +++++++++++++++++++++++
> >> >  2 files changed, 26 insertions(+), 0 deletions(-)
> >> >  create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
> >> >
> >> > diff --git a/arch/arm/mach-w90x900/include/mach/clkdev.h
> >> > b/arch/arm/mach-w90x900/include/mach/clkdev.h
> >> > index 04b37a8..b35f4bc 100644
> >> > --- a/arch/arm/mach-w90x900/include/mach/clkdev.h
> >> > +++ b/arch/arm/mach-w90x900/include/mach/clkdev.h
> >> > @@ -4,4 +4,7 @@
> >> >  #define __clk_get(clk) ({ 1; })
> >> >  #define __clk_put(clk) do { } while (0)
> >> >
> >> > +extern void nuc900_driver_clksrc_div(struct device *dev, unsigned
> char
> >> > *src,
> >> > +                                                     unsigned char
> >> > divider);
> >> > +
> >>
> >> I'd prefer it if this header didn't get used for non-clkdev<->plat code
> >> stuff.
> >
> > So, you mean I can use this header in the LCD driver of nuc900 plat?
> >
>
> Hmmm, I don't think so.
>
> I think it is better to implement other API as Ben Dooks mentioned,
> but if you want to use
> this API provided by me, we have to add the extern to other header
> file rather than the specific clkdev header file.
>
> So, please wait me for new patch.


Ok, thank you.
I can not display the Linux Logo correctly.
I debug the kernel, it gave the wrong size of logo cols x rows = 40 x 15.
Any Idea?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100105/d911113b/attachment-0001.htm>