[PATCH] ep93xx: Add support for Simplemachines Sim.One board

[PATCH] ep93xx: Add support for Simplemachines Sim.One board

[Ryan Mallon]

The following patch adds support for the ep9307 based Sim.One board from
Simplemachines. The code is based on the patches from Simplemachines for
the 2.6.24.7 kernel available here:
http://sim1.googlecode.com/files/linux-2.6.24.7-patches-20091001.tgz.
Support for  SPI and Audio is not included since we do not support them
in mainline yet. The framebuffer support has been tested with a standard
desktop monitor. LCD support is not included because I do not have
hardware to test.

I have specified the maintainer for this board as Nuccio Raciti (CC'ed),
who is the maintainer for Simplemachine's 2.6.24.7 patches. If this is
not okay, I can put myself as the maintainer.

Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
Cc: Nuccio Raciti <nuccio.raciti@gmail.com>
Cc: Peter Ivanov <ivanovp@gmail.com>
Cc: Sergio Sorrenti <sergio.sorrenti@gmail.com>
Cc: Hartley Sweeten <hartleys@visionengravers.com>
----

diff --git a/arch/arm/mach-ep93xx/Kconfig b/arch/arm/mach-ep93xx/Kconfig
index 9167c3d..a8b2035 100644
--- a/arch/arm/mach-ep93xx/Kconfig
+++ b/arch/arm/mach-ep93xx/Kconfig
@@ -168,6 +168,13 @@ config MACH_TS72XX
 	  Say 'Y' here if you want your kernel to support the
 	  Technologic Systems TS-72xx board.

+config MACH_SIM_ONE
+        bool "Support Simplemachines Sim.One board"
+        depends on EP93XX_SDCE0_PHYS_OFFSET
+        help
+          Say 'Y' here if you want your kernel to support the
+          Simplemachines Sim.One board.
+
 choice
 	prompt "Select a UART for early kernel messages"

diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
index eae6199..01d90e1 100644
--- a/arch/arm/mach-ep93xx/Makefile
+++ b/arch/arm/mach-ep93xx/Makefile
@@ -11,3 +11,4 @@ obj-$(CONFIG_MACH_EDB93XX)	+= edb93xx.o
 obj-$(CONFIG_MACH_GESBC9312)	+= gesbc9312.o
 obj-$(CONFIG_MACH_MICRO9)	+= micro9.o
 obj-$(CONFIG_MACH_TS72XX)	+= ts72xx.o
+obj-$(CONFIG_MACH_SIM_ONE)	+= simone.o
diff --git a/arch/arm/mach-ep93xx/simone.c b/arch/arm/mach-ep93xx/simone.c
new file mode 100644
index 0000000..fb3ef1f
--- /dev/null
+++ b/arch/arm/mach-ep93xx/simone.c
@@ -0,0 +1,77 @@
+/*
+ * arch/arm/mach-ep93xx/simone.c
+ * Simplemachines Sim.One support.
+ *
+ * Copyright (C) 2009 Ryan Mallon <ryan@bluewatersys.com>
+ *
+ * Based on the 2.6.24 support:
+ *   Copyright (C) 2009 Simplemachines
+ *   MMC support by Peter Ivanov <ivanovp@gmail.com>, 2007
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/mtd/physmap.h>
+
+#include <mach/hardware.h>
+#include <mach/fb.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+
+static struct physmap_flash_data simone_flash_data = {
+	.width		= 2,
+};
+
+static struct resource simone_flash_resource = {
+	.start		= 0x60000000,
+	.end		= 0x60000000 + SZ_8M - 1,
+	.flags		= IORESOURCE_MEM,
+};
+
+static struct platform_device simone_flash = {
+	.name		= "physmap-flash",
+	.id		= 0,
+	.num_resources	= 1,
+	.resource	= &simone_flash_resource,
+	.dev = {
+		.platform_data	= &simone_flash_data,
+	},	
+};
+
+static struct ep93xx_eth_data simone_eth_data = {
+	.phy_id		= 1,
+};
+
+static struct ep93xxfb_mach_info simone_fb_info = {
+	.num_modes	= EP93XXFB_USE_MODEDB,
+	.bpp		= 16,
+	.flags		= EP93XXFB_PCLK_FALLING,
+};
+
+static void __init simone_init_machine(void)
+{
+	ep93xx_init_devices();
+	
+	platform_device_register(&simone_flash);
+	ep93xx_register_eth(&simone_eth_data, 1);
+	ep93xx_register_fb(&simone_fb_info);
+}
+
+MACHINE_START(SIM_ONE, "Simplemachines Sim.One Board")
+/* Maintainer: Nuccio Raciti Simplemachine <nuccio.raciti@gmail.com> */
+	.phys_io	= EP93XX_APB_PHYS_BASE,
+	.io_pg_offst	= ((EP93XX_APB_VIRT_BASE) >> 18) & 0xfffc,
+	.boot_params	= EP93XX_SDCE0_PHYS_BASE + 0x00000100,
+	.map_io		= ep93xx_map_io,
+	.init_irq	= ep93xx_init_irq,
+	.timer		= &ep93xx_timer,
+	.init_machine	= simone_init_machine,
+MACHINE_END

[PATCH] ep93xx: Add support for Simplemachines Sim.One board

[Ryan Mallon]

H Hartley Sweeten wrote:
> On Wednesday, January 20, 2010 12:59 PM, Ryan Mallon wrote:
>   
>> The following patch adds support for the ep9307 based Sim.One board from
>> Simplemachines. The code is based on the patches from Simplemachines for
>> the 2.6.24.7 kernel available here:
>> http://sim1.googlecode.com/files/linux-2.6.24.7-patches-20091001.tgz.
>> Support for  SPI and Audio is not included since we do not support them
>> in mainline yet. The framebuffer support has been tested with a standard
>> desktop monitor. LCD support is not included because I do not have
>> hardware to test.
>>
>> I have specified the maintainer for this board as Nuccio Raciti (CC'ed),
>> who is the maintainer for Simplemachine's 2.6.24.7 patches. If this is
>> not okay, I can put myself as the maintainer.
>>
>> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
>> Cc: Nuccio Raciti <nuccio.raciti@gmail.com>
>> Cc: Peter Ivanov <ivanovp@gmail.com>
>> Cc: Sergio Sorrenti <sergio.sorrenti@gmail.com>
>> Cc: Hartley Sweeten <hartleys@visionengravers.com>
>> ----
>>     
>
> Ryan,
>
> Thanks for doing this.  I had a similar patch almost ready but have not
> had the time to finish it.
>
> A couple comments below.
>
>

(Fixed the ARM kernel list Cc, I accidentally sent it to the old list
server originally. Can people please reply to this email rather than the
other one so the ARM kernel list gets Cc'ed correctly.)

Thanks. I have also changed the maintainer to me, which is just easier I
think. Updated patch below:
----

diff --git a/arch/arm/mach-ep93xx/Kconfig b/arch/arm/mach-ep93xx/Kconfig
index 9167c3d..5231a3a 100644
--- a/arch/arm/mach-ep93xx/Kconfig
+++ b/arch/arm/mach-ep93xx/Kconfig
@@ -161,6 +161,13 @@ config MACH_MICRO9S
 	  Say 'Y' here if you want your kernel to support the
 	  Contec Micro9-Slim board.

+config MACH_SIM_ONE
+        bool "Support Simplemachines Sim.One board"
+        depends on EP93XX_SDCE0_PHYS_OFFSET
+        help
+          Say 'Y' here if you want your kernel to support the
+          Simplemachines Sim.One board.
+
 config MACH_TS72XX
 	bool "Support Technologic Systems TS-72xx SBC"
 	depends on EP93XX_SDCE3_SYNC_PHYS_OFFSET
diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
index eae6199..c731fa9 100644
--- a/arch/arm/mach-ep93xx/Makefile
+++ b/arch/arm/mach-ep93xx/Makefile
@@ -10,4 +10,5 @@ obj-$(CONFIG_MACH_ADSSPHERE)	+= adssphere.o
 obj-$(CONFIG_MACH_EDB93XX)	+= edb93xx.o
 obj-$(CONFIG_MACH_GESBC9312)	+= gesbc9312.o
 obj-$(CONFIG_MACH_MICRO9)	+= micro9.o
+obj-$(CONFIG_MACH_SIM_ONE)	+= simone.o
 obj-$(CONFIG_MACH_TS72XX)	+= ts72xx.o
diff --git a/arch/arm/mach-ep93xx/simone.c b/arch/arm/mach-ep93xx/simone.c
new file mode 100644
index 0000000..c589031
--- /dev/null
+++ b/arch/arm/mach-ep93xx/simone.c
@@ -0,0 +1,97 @@
+/*
+ * arch/arm/mach-ep93xx/simone.c
+ * Simplemachines Sim.One support.
+ *
+ * Copyright (C) 2009 Ryan Mallon <ryan@bluewatersys.com>
+ *
+ * Based on the 2.6.24.7 support:
+ *   Copyright (C) 2009 Simplemachines
+ *   MMC support by Peter Ivanov <ivanovp@gmail.com>, 2007
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/mtd/physmap.h>
+#include <linux/gpio.h>
+#include <linux/i2c.h>
+#include <linux/i2c-gpio.h>
+
+#include <mach/hardware.h>
+#include <mach/fb.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+
+static struct physmap_flash_data simone_flash_data = {
+	.width		= 2,
+};
+
+static struct resource simone_flash_resource = {
+	.start		= EP93XX_CS6_PHYS_BASE,
+	.end		= EP93XX_CS6_PHYS_BASE + SZ_8M - 1,
+	.flags		= IORESOURCE_MEM,
+};
+
+static struct platform_device simone_flash = {
+	.name		= "physmap-flash",
+	.id		= 0,
+	.num_resources	= 1,
+	.resource	= &simone_flash_resource,
+	.dev = {
+		.platform_data	= &simone_flash_data,
+	},
+};
+
+static struct ep93xx_eth_data simone_eth_data = {
+	.phy_id		= 1,
+};
+
+static struct ep93xxfb_mach_info simone_fb_info = {
+	.num_modes	= EP93XXFB_USE_MODEDB,
+	.bpp		= 16,
+	.flags		= EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
+};
+
+static struct i2c_gpio_platform_data simone_i2c_gpio_data = {
+	.sda_pin		= EP93XX_GPIO_LINE_EEDAT,
+	.sda_is_open_drain	= 0,
+	.scl_pin		= EP93XX_GPIO_LINE_EECLK,
+	.scl_is_open_drain	= 0,
+	.udelay			= 0,
+	.timeout		= 0,
+};
+
+static struct i2c_board_info __initdata simone_i2c_board_info[] = {
+	{
+		I2C_BOARD_INFO("ds1337", 0x68),
+	},
+};
+
+static void __init simone_init_machine(void)
+{
+	ep93xx_init_devices();
+
+	platform_device_register(&simone_flash);
+	ep93xx_register_eth(&simone_eth_data, 1);
+	ep93xx_register_i2c(&simone_i2c_gpio_data, simone_i2c_board_info,
+			    ARRAY_SIZE(simone_i2c_board_info));
+	ep93xx_register_fb(&simone_fb_info);
+}
+
+MACHINE_START(SIM_ONE, "Simplemachines Sim.One Board")
+/* Maintainer: Ryan Mallon <ryan@bluewatersys.com> */
+	.phys_io	= EP93XX_APB_PHYS_BASE,
+	.io_pg_offst	= ((EP93XX_APB_VIRT_BASE) >> 18) & 0xfffc,
+	.boot_params	= EP93XX_SDCE0_PHYS_BASE + 0x100,
+	.map_io		= ep93xx_map_io,
+	.init_irq	= ep93xx_init_irq,
+	.timer		= &ep93xx_timer,
+	.init_machine	= simone_init_machine,
+MACHINE_END

[PATCH] ep93xx: Add support for Simplemachines Sim.One board

[Ryan Mallon]

H Hartley Sweeten wrote:
> On Wednesday, January 20, 2010 1:35 PM, Ryan Mallon wrote:
>   
>> H Hartley Sweeten wrote:
>>     
>>
>
> Two minor nitpicks below...
>
>   
>> --- /dev/null
>> +++ b/arch/arm/mach-ep93xx/simone.c
>> @@ -0,0 +1,97 @@
>> +/*
>> + * arch/arm/mach-ep93xx/simone.c
>> + * Simplemachines Sim.One support.
>> + *
>> + * Copyright (C) 2009 Ryan Mallon <ryan@bluewatersys.com>
>>     
>
> 2010?
>   
I started writing the patch last year, hence the 2009. Can update if
necessary.
>> +static struct ep93xxfb_mach_info simone_fb_info = {
>> +	.num_modes	= EP93XXFB_USE_MODEDB,
>> +	.bpp		= 16,
>> +	.flags		= EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
>> +};
>>     
>
> Nitpick.. Please put the fb stuff above after the i2c stuff below.
>   
Can do if necessary. Its pretty minor though.
>
> Did you happen to look at the patch I sent on 12/23/2009 with subject
> [PATCH] ep93xx: add missing SDRAM options for EDB93xx
>
> I think the EP93XX_SDCE0_PHYS_BASE can be changed to PHYS_OFFSET in
> all the ep93xx platform init code.  I'm not sure what Uwe Kleine-K?nig
> is going to do with the run time determined PHYS_OFFSET but I think
> that would at least get ep93xx ready for it.
>   
The other boards are all still using the old way. I can change this
board now, or just leave as is and we can change all of the boards later?
>  
> Other that that, looks good to me.  This pretty much matches what I had
> pending.  Have you at least compile tested this?
>
> It would be nice if someone could actually test this to make sure the
> kernel boots correctly on the Sim.One.  But for what it's worth:
>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>   
I'll wait on the guys from Simplemachines to have their say before I put
this into the patch system.

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751 
Fax:   +64 3 3779135			  USA 1800 261 2934