From: andy@warmcat.com (Andy Green)
To: linux-arm-kernel@lists.infradead.org
Subject: Device probe order (i2c regulator vs. platform device)
Date: Wed, 24 Mar 2010 12:11:41 +0000 [thread overview]
Message-ID: <4BAA017D.70503@warmcat.com> (raw)
In-Reply-To: <20100324113241.GC5831@opensource.wolfsonmicro.com>
On 03/24/10 11:32, Somebody in the thread at some point said:
> On Wed, Mar 24, 2010 at 09:19:58AM +0000, Andy Green wrote:
>
>> Delaying registering devices is only half the problem. You must
>> also correct these device's parent dev to be the PMU's.
>
>> Otherwise your suspend and resume ordering turns to crap and you
>> will immediately be in Hell, for example the PMIC may go down taking
>> away power from the SD Card before you finished talking to it.
>
> This has not been a practical issue in systems - it is very rare to
You evidently know about GTA02...
> explicitly suspend the regulator part of the PMIC. Obviously the PMIC
> suspend will usually involve killing the power to the processor so it is
> almost always triggered from hardware as part of the processor poweroff
> after software has halted.
That doesn't have to follow at all, there are various kinds of suspend
and it's legal for the PMU to have a policy to turn off various assets
at the various levels of power saving. Nor if I understood it is
regulator API requiring a handshake signal scheme from the CPU to manage
suspend, it's open how it is done and supports regulators and CPUs that
don't have that arrangement.
> It'd be nice to explicitly save and restore the regulator state over
> suspend and resume for devices that don't support that natively but
> that's mostly orthogonal and mostly just flops out of devices doing
> their own management at suspend and resume anyway.
>
>> It would be very good is this was regularized somehow into a
>> standard API because it's absolutely a requirement for many boards
>> that their devices ARE dependent on PMU as a parent.
>
> The only system I'm aware of which had any stuff like this was the
> GTA02. I never investigated to figure out why the code there was doing
> what it was.
I wouldn't be so quick to assert that, you do not know all the code out
there in order to tell. I seem to read threads regularly here about
furrowed brows on unstable or broken suspend that can easily be due to
this kind of race.
Anyway, you reject it's a problem, understood :-)
-Andy
next prev parent reply other threads:[~2010-03-24 12:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 7:10 Device probe order (i2c regulator vs. platform device) Marek Szyprowski
2010-03-24 9:19 ` Andy Green
2010-03-24 11:11 ` Marek Szyprowski
2010-03-24 12:50 ` Andy Green
2010-03-24 13:11 ` Mark Brown
2010-03-24 13:22 ` Andy Green
2010-03-24 11:32 ` Mark Brown
2010-03-24 12:11 ` Andy Green [this message]
2010-03-24 14:01 ` Mark Brown
2010-03-24 14:38 ` Andy Green
2010-03-25 10:22 ` Mark Brown
2010-03-25 10:52 ` Andy Green
2010-03-24 10:21 ` Mark Brown
2010-03-24 10:57 ` Andy Green
2010-03-24 11:02 ` Marek Szyprowski
2010-03-24 11:08 ` Mark Brown
2010-03-24 11:27 ` Andy Green
2010-03-24 12:19 ` Mark Brown
2010-03-24 12:29 ` Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAA017D.70503@warmcat.com \
--to=andy@warmcat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).