[PATCH] fec.c: Fix memory corruption in fec_set_mac_address.

[PATCH] fec.c: Fix memory corruption in fec_set_mac_address.

[Mattias Walstrom]

Fix memory corruption that may result in kernel panics.

Signed-off-by: Mattias Walstr?m <mattias@vmlinux.org>

fec.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 9f98c1c..9b4e8f7 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1653,7 +1653,7 @@ fec_set_mac_address(struct net_device *dev, void *p)
 		(dev->dev_addr[1] << 16) | (dev->dev_addr[0] << 24),
 		fep->hwp + FEC_ADDR_LOW);
 	writel((dev->dev_addr[5] << 16) | (dev->dev_addr[4] << 24),
-		fep + FEC_ADDR_HIGH);
+		fep->hwp + FEC_ADDR_HIGH);
 	return 0;
 }
 

[PATCH] fec.c: Fix memory corruption in fec_set_mac_address.

[Uwe Kleine-König]

Hi Mattias,

On Sun, May 02, 2010 at 10:32:24PM +0200, Mattias Walstrom wrote:
> Fix memory corruption that may result in kernel panics.
> 
> Signed-off-by: Mattias Walstr?m <mattias@vmlinux.org>
> 
You might want to send this to netdev and make sure to keep the diffstat
out of the changelog.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH] fec.c: Fix memory corruption in fec_set_mac_address.

[Baruch Siach]

Hi Uwe, Mattias,

On Wed, May 05, 2010 at 10:15:14PM +0200, Uwe Kleine-K?nig wrote:
> On Sun, May 02, 2010 at 10:32:24PM +0200, Mattias Walstrom wrote:
> > Fix memory corruption that may result in kernel panics.
> > 
> > Signed-off-by: Mattias Walstr?m <mattias@vmlinux.org>
> > 
> You might want to send this to netdev and make sure to keep the diffstat
> out of the changelog.

This is already applied upstream (7cff0943a).

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -