[PATCH 17/20] pxa3xx_nand: add cmdline part parser support

[mkl@pengutronix.de (Marc Kleine-Budde)]

Haojian Zhuang wrote:
> On Fri, May 14, 2010 at 4:41 PM, Daniel Mack <daniel@caiaq.de> wrote:
>> On Fri, May 14, 2010 at 09:16:11AM +0100, David Woodhouse wrote:
>>> On Fri, 2010-05-14 at 14:08 +0800, Haojian Zhuang wrote:
>>>> New patches are rebased for mtd-2.6 master branch. There're contained
>>>> in another mail loop.
>>> Hm, please test these by sending to yourself first, saving the patches
>>> and checking that they apply.
>>>
>>> [dwmw2 at macbook mtd-2.6]$ git describe HEAD
>>> v2.6.34-rc7-142-gf6b173c
>>>
>>> [dwmw2 at macbook mtd-2.6]$ for a in `seq -w 1 20` ; do echo Patch $a ; patch -p1 < pxa$a.patch ; done
>>> Patch 01
>>> patching file arch/arm/plat-pxa/include/plat/pxa3xx_nand.h
>>> patching file drivers/mtd/nand/Kconfig
>>> patching file drivers/mtd/nand/pxa3xx_nand.c
>>> patch: **** malformed patch at line 203: transfering to/from NAND HW");
>> Jep, they're line-wrapped, just like the version before.
>>
>> Haojian, you can avoid this to happen by using 'git send-email'.
>>
>> Thanks,
>> Daniel
>>
> 
> Now I attach these patches directly. Only 0011 patch is changed to
> using dev_dbg for debug print.

I NACK patches 1 and 17. See my reply to these individual patches.

Cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100514/f0167d1c/attachment.sig>