From: skannan@codeaurora.org (Saravana Kannan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] [ARM] Add ARCH_PROVIDES_UDELAY config option
Date: Fri, 21 May 2010 15:10:55 -0700 [thread overview]
Message-ID: <4BF704EF.8000605@codeaurora.org> (raw)
In-Reply-To: <20100521220653.GL11042@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote:
> On Fri, May 21, 2010 at 03:01:48PM -0700, Saravana Kannan wrote:
>> Russell King - ARM Linux wrote:
>>> We may be running into the same problem which we did with the printk
>>> clock - that is using a machine provided sched_clock() or clocksource
>>> requires MMIO accesses, which can only be done after the IO mappings
>>> have been initialized.
>>>
>>> Let's hope no one ever uses udelay() before the necessary IO mappings
>>> are present.
>> Is the patch that uses CONFIG_ARCH_PROVIDES_UDELAY acceptable? I don't
>> care much for how each arch decides to implement it, but I think we
>> should have this config to let each arch decide how they want to handle
>> udelay.
>>
>> I personally prefer not to use the sched clock source due to the
>> unnecessary complexities. If you have a some kind of constant counter,
>> it sounds much simpler to just use it instead of adding dependencies
>> between udelay and sched clock.
>
> My point is not specific to sched_clock, but to counters which on ARM
> are 99.9% always memory mapped, and therefore inaccessible during the
> very early kernel boot. sched_clock was merely an illustration of the
> problem.
Agree with the point about the counters being memory mapped. But does
any of the really early init code use udelay? AFAIK, udelay is mostly
used when talking to devices at which point IO mapping needs to have
been completed to be able to talk to the device in the first place.
Even otherwise, a given arch might not need udelay during early init
code. So, we could still give them that option. No?
-Saravana
next prev parent reply other threads:[~2010-05-21 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 19:12 [PATCH V2] [ARM] Add ARCH_PROVIDES_UDELAY config option Colin Cross
2010-04-30 19:37 ` Colin Cross
2010-04-30 22:11 ` Kevin Hilman
2010-05-01 0:04 ` Saravana Kannan
2010-05-01 10:01 ` Russell King - ARM Linux
2010-05-21 22:01 ` Saravana Kannan
2010-05-21 22:06 ` Russell King - ARM Linux
2010-05-21 22:10 ` Saravana Kannan [this message]
2010-05-28 0:41 ` Saravana Kannan
2010-06-22 1:14 ` Saravana Kannan
2010-06-28 2:30 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF704EF.8000605@codeaurora.org \
--to=skannan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).