From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] i.MX27: add suspend to RAM support
Date: Thu, 27 May 2010 22:06:04 +0200 [thread overview]
Message-ID: <4BFED0AC.6000604@eukrea.com> (raw)
In-Reply-To: <20100527194305.GB25921@n2100.arm.linux.org.uk>
Hi Russell,
Le 27/05/2010 21:43, Russell King - ARM Linux a ?crit :
> On Thu, May 27, 2010 at 04:13:55PM +0200, Eric B?nard wrote:
>> +#include<linux/kernel.h>
>> +#include<linux/suspend.h>
>> +#include<asm/io.h>
>
> linux/io.h
>
OK sorry for this one, you already told me this at the first review and
I forget to fix it.
> (checkpatch.pl will tell you this, although the general rule that "if
> there's a linux/foo.h and an asm/foo.h, linux/foo.h should be used"
> doesn't always apply - there are some exceptions.)
>
In fact checkpatch only returned the following warning (which I didn't
fixed as I didn't found any platform_suspend_ops which is const).
Do you think I should also fix this warning ?
./linux-2.6/scripts/checkpatch.pl
0001-i.MX27-add-suspend-to-RAM-support.patch
WARNING: struct platform_suspend_ops should normally be const
#72: FILE: arch/arm/mach-mx2/pm-imx27.c:35:
+static struct platform_suspend_ops mx27_suspend_ops = {
total: 0 errors, 1 warnings, 54 lines checked
0001-i.MX27-add-suspend-to-RAM-support.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Eric
next prev parent reply other threads:[~2010-05-27 20:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 6:33 [PATCH v2 1/8] i.MX27: add suspend to RAM support Eric Bénard
2010-05-27 6:33 ` [PATCH v2 2/8] mxc_nand: fix PM Eric Bénard
2010-05-27 6:33 ` [PATCH v2 3/8] imx_keypad: add PM support Eric Bénard
2010-05-27 6:33 ` [PATCH v2 4/8] eukrea_mbimx27: update keyboard platform data Eric Bénard
2010-05-27 6:33 ` [PATCH v2 5/8] serial/imx.c: fix suspend/resume Eric Bénard
2010-05-27 6:33 ` [PATCH v2 6/8] serial/imx: drvdata is sport and not &sport->port Eric Bénard
2010-05-27 6:33 ` [PATCH v2 7/8] net/fec: fix pm to survive to suspend/resume Eric Bénard
2010-05-27 6:33 ` [PATCH v2 8/8] imxfb: fix PM Eric Bénard
2010-05-27 10:37 ` [PATCH v2 7/8] net/fec: fix pm to survive to suspend/resume Sergei Shtylyov
2010-05-27 14:19 ` [PATCH v3] " Eric Bénard
2010-05-27 17:09 ` Fabio Estevam
2010-05-27 17:53 ` [PATCH] " Eric Bénard
2010-05-29 7:15 ` David Miller
2010-05-29 20:04 ` [PATCH v2] " Eric Bénard
2010-06-02 13:13 ` David Miller
2010-05-29 12:23 ` [PATCH v2 3/8] imx_keypad: add PM support Alberto Panizzo
2010-05-30 8:51 ` [PATCH] " Eric Bénard
2010-06-02 8:02 ` Dmitry Torokhov
2010-05-27 17:55 ` [PATCH] mxc_nand: fix PM Eric Bénard
2010-06-14 7:07 ` Eric Bénard
2010-06-29 6:41 ` Artem Bityutskiy
2010-07-01 3:47 ` Artem Bityutskiy
2010-06-14 8:43 ` Uwe Kleine-König
2010-05-27 14:13 ` [PATCH v3] i.MX27: add suspend to RAM support Eric Bénard
2010-05-27 19:43 ` Russell King - ARM Linux
2010-05-27 20:06 ` Eric Bénard [this message]
2010-05-27 20:16 ` Russell King - ARM Linux
2010-05-27 20:48 ` [PATCH v4] " Eric Bénard
2010-05-27 20:54 ` [PATCH v3] " Eric Bénard
2010-05-27 21:46 ` Russell King - ARM Linux
2010-06-01 19:57 ` [PATCH v5] " Eric Bénard
2010-06-03 8:28 ` Sascha Hauer
2010-05-27 21:13 ` [PATCH v3] " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFED0AC.6000604@eukrea.com \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).