* [PATCHv2 1/3] MTD/pxa: use __devinit for pxa2xx_flash_probe
@ 2010-06-05 9:07 Wan ZongShun
2010-06-05 17:18 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Wan ZongShun @ 2010-06-05 9:07 UTC (permalink / raw)
To: linux-arm-kernel
This patch is to use the '__devinit' for pxa2xx_flash_probe.
Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
---
drivers/mtd/maps/pxa2xx-flash.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
index dd90880..d8ae634 100644
--- a/drivers/mtd/maps/pxa2xx-flash.c
+++ b/drivers/mtd/maps/pxa2xx-flash.c
@@ -51,7 +51,7 @@ struct pxa2xx_flash_info {
static const char *probes[] = { "RedBoot", "cmdlinepart", NULL };
-static int __init pxa2xx_flash_probe(struct platform_device *pdev)
+static int __devinit pxa2xx_flash_probe(struct platform_device *pdev)
{
struct flash_platform_data *flash = pdev->dev.platform_data;
struct pxa2xx_flash_info *info;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCHv2 1/3] MTD/pxa: use __devinit for pxa2xx_flash_probe
2010-06-05 9:07 [PATCHv2 1/3] MTD/pxa: use __devinit for pxa2xx_flash_probe Wan ZongShun
@ 2010-06-05 17:18 ` Sergei Shtylyov
2010-06-06 9:27 ` Eric Miao
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2010-06-05 17:18 UTC (permalink / raw)
To: linux-arm-kernel
Wan ZongShun wrote:
> This patch is to use the '__devinit' for pxa2xx_flash_probe.
Why? Is it hot-pluggable device? I guess not...
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> Acked-by: Eric Miao <eric.y.miao@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCHv2 1/3] MTD/pxa: use __devinit for pxa2xx_flash_probe
2010-06-05 17:18 ` Sergei Shtylyov
@ 2010-06-06 9:27 ` Eric Miao
0 siblings, 0 replies; 3+ messages in thread
From: Eric Miao @ 2010-06-06 9:27 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jun 6, 2010 at 1:18 AM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Wan ZongShun wrote:
>
>> This patch is to use the '__devinit' for pxa2xx_flash_probe.
>
> ? Why? Is it hot-pluggable device? I guess not...
>
Then I guess the __devexit is not applicable to pxa2xx_flash_remove as well.
Apart from the _probe() being unnecessarily built in when HOTPLUG is
defined, is there any drawbacks. It does make code a little bit consistent
from my POV.
>> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
>> Acked-by: Eric Miao <eric.y.miao@gmail.com>
>
> WBR, Sergei
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-06 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-05 9:07 [PATCHv2 1/3] MTD/pxa: use __devinit for pxa2xx_flash_probe Wan ZongShun
2010-06-05 17:18 ` Sergei Shtylyov
2010-06-06 9:27 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).