From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] USB: s3c-hsotg: Fix the OUT EP0 limit
Date: Fri, 11 Jun 2010 11:01:18 +0200 [thread overview]
Message-ID: <4C11FB5E.8060106@gmail.com> (raw)
In-Reply-To: <1276244457-4072-11-git-send-email-ben-linux@fluff.org>
Op 11-06-10 10:20, Ben Dooks schreef:
> The EP0 out limit is the same as the IN limit, so make them the same.
>
> Signed-off-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
>
> tmp-fix
Shouldn't this line be removed?
> ---
> drivers/usb/gadget/s3c-hsotg.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 17b0779..b34a05d 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -612,11 +612,10 @@ static unsigned get_ep_limit(struct s3c_hsotg_ep *hs_ep)
> maxsize = S3C_DxEPTSIZ_XferSize_LIMIT + 1;
> maxpkt = S3C_DxEPTSIZ_PktCnt_LIMIT + 1;
> } else {
> + maxsize = 64+64;
> if (hs_ep->dir_in) {
> - maxsize = 64+64;
> maxpkt = S3C_DIEPTSIZ0_PktCnt_LIMIT + 1;
> } else {
> - maxsize = 0x3f;
> maxpkt = 2;
> }
> }
next prev parent reply other threads:[~2010-06-11 9:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 8:20 s3c-hsotg fixes Ben Dooks
2010-06-11 8:20 ` [PATCH 01/11] USB: s3c_hsotg: Add support for external USB clock Ben Dooks
2010-06-11 9:35 ` Marek Szyprowski
2010-06-11 9:46 ` Maurus Cuelenaere
2010-06-11 8:20 ` [PATCH 02/11] USB: s3c-hsotg: Increase TX fifo limit Ben Dooks
2010-06-11 8:20 ` [PATCH 03/11] USB: s3c-hsotg: The NPTX/PTX FIFO sizes are in words, not bytes Ben Dooks
2010-06-11 8:20 ` [PATCH 04/11] USB: s3c-hsotg: Avoid overwriting contents of perodic in 'fifo' Ben Dooks
2010-06-11 8:20 ` [PATCH 05/11] USB: s3c-hsotg: Re-initialise all FIFOs on USB bus reset Ben Dooks
2010-06-11 8:20 ` [PATCH 06/11] USB: s3c-hsotg: Add initial detection and setup for dedicated FIFO mode Ben Dooks
2010-06-11 8:54 ` Maurus Cuelenaere
2010-06-11 8:20 ` [PATCH 07/11] USB: s3c-hsotg: Only load packet per fifo write Ben Dooks
2010-06-11 8:20 ` [PATCH 08/11] USB: s3c-hsotg: Check for new request before enqueing new setup Ben Dooks
2010-06-11 8:20 ` [PATCH 09/11] USB: s3c-hsotg: Fix max EP0 IN request length Ben Dooks
2010-06-11 8:20 ` [PATCH 10/11] USB: s3c-hsotg: Fix the OUT EP0 limit Ben Dooks
2010-06-11 9:01 ` Maurus Cuelenaere [this message]
2010-06-11 9:07 ` Marek Szyprowski
2010-06-11 8:20 ` [PATCH 11/11] USB: s3c-hsotg: Fix OUT packet request retry Ben Dooks
2010-06-11 10:25 ` s3c-hsotg fixes Marek Szyprowski
2010-06-12 3:34 ` Ben Dooks
2010-06-14 5:40 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C11FB5E.8060106@gmail.com \
--to=mcuelenaere@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).