From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason77.wang@gmail.com (jason) Date: Fri, 18 Jun 2010 22:06:34 +0800 Subject: [PATCH 1/2] mxc: add common debug board for 3-stack platforms In-Reply-To: <20100616065540.GI20799@pengutronix.de> References: <1276352707-8199-1-git-send-email-jason77.wang@gmail.com> <1276352707-8199-2-git-send-email-jason77.wang@gmail.com> <20100616065540.GI20799@pengutronix.de> Message-ID: <4C1B7D6A.4010301@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sascha Hauer wrote: > On Sat, Jun 12, 2010 at 10:25:06PM +0800, Jason Wang wrote: > >> The debug board is little different for all mxc 3-stack(PDK) >> platforms, it is possible here to add a common implementation to >> support this board. >> > > Two small things left: > > Could you change the name cpld_debugboard.c to something like > 3ds_debugboard.c? That we are talking about the 3ds is much more > interesting than that there's a cpld on the board. > > Also, I really prefer having no extra header file for the debug board. > All information in this header file is only interesting in this single C > file. > > Sascha > > > Hi Sascha, About the header file, most contents can be moved to c file, but there are two declarations: extern struct platform_device smsc_lan9217_device; int __init mxc_expio_init(u32 base, u32 p_irq); which will be used by board_mxNN_3ds.c, should i move them to mach/common.h and drop 3ds_debugboard.h or keep them in 3ds_debugboard.h? Thanks, Jason. >> Signed-off-by: Jason Wang >> --- >> arch/arm/plat-mxc/Kconfig | 11 ++ >> arch/arm/plat-mxc/Makefile | 1 + >> arch/arm/plat-mxc/cpld_debugboard.c | 161 ++++++++++++++++++++++ >>