linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ASoC: Add SmartQ sound driver
Date: Sun, 04 Jul 2010 11:19:37 +0200	[thread overview]
Message-ID: <4C305229.30409@gmail.com> (raw)
In-Reply-To: <20100704090549.GD16825@opensource.wolfsonmicro.com>

 Op 04-07-10 11:05, Mark Brown schreef:
> On Sat, Jul 03, 2010 at 02:46:12AM +0200, Maurus Cuelenaere wrote:
>> This adds sound support for the SmartQ board.
>>
>> The hardware consists of a S3C6410 coupled with a WM8987 over I?S. The WM8750
>> driver is used for driving the WM8987, as they are register compatible.
> I've applied this, but...
>
>> +static struct snd_soc_jack_pin smartq_jack_pins[] = {
>> +	/* Disable speaker when headphone is plugged in */
>> +	{
>> +		.pin	= "Internal Speaker",
>> +		.mask	= SND_JACK_HEADPHONE,
>> +		.invert	= true,
>> +	},
>> +};
> ...it probably also make sense to disable the headphone output when the
> headphone is not plugged in to save power?

I don't see what power there is to save? The speaker and headphone jack are connected to the same physical pins, so when disabling the pins for one of them, the other is also disabled.

The only way to disable the speaker is to shutdown its amplifier (using that GPIO pin).

-- 
Maurus Cuelenaere

  reply	other threads:[~2010-07-04  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-03  0:46 [PATCH 2/3] ASoC: Add SmartQ sound driver Maurus Cuelenaere
2010-07-04  9:05 ` Mark Brown
2010-07-04  9:19   ` Maurus Cuelenaere [this message]
2010-07-04  9:42     ` Mark Brown
2010-07-04  9:45       ` Maurus Cuelenaere
2010-07-04 10:03 ` Maurus Cuelenaere
2010-07-04 13:01   ` Mark Brown
2010-07-04 13:12     ` [PATCH] ASoC: Invert speaker enabling behaviour in " Maurus Cuelenaere
2010-07-06  8:07       ` [alsa-devel] " Liam Girdwood
2010-07-06 14:54         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C305229.30409@gmail.com \
    --to=mcuelenaere@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).