From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: SAMSUNG: Add device definition for HSMMC3
Date: Sun, 04 Jul 2010 11:22:59 +0200 [thread overview]
Message-ID: <4C3052F3.4080208@gmail.com> (raw)
In-Reply-To: <009501cb1a4e$04f57ec0$0ee07c40$%kim@samsung.com>
Op 03-07-10 03:21, Kukjin Kim schreef:
> Maurus Cuelenaere wrote:
>> Op 03-07-10 02:07, Kukjin Kim schreef:
>>
>>> /* S3C6400 SDHCI setup */
>>>
>>> @@ -264,10 +267,22 @@ static inline void s5pv210_default_sdhci2(void)
>>> static inline void s5pv210_default_sdhci2(void) { }
>>> #endif /* CONFIG_S3C_DEV_HSMMC2 */
>>>
>>> +#ifdef CONFIG_S3C_DEV_HSMMC3
>>> +static inline void s5pv210_default_sdhci3(void)
>>> +{
>>> + s3c_hsmmc3_def_platdata.clocks = s5pv210_hsmmc_clksrcs;
>>> + s3c_hsmmc3_def_platdata.cfg_gpio = s5pv210_setup_sdhci3_cfg_gpio;
>>> + s3c_hsmmc3_def_platdata.cfg_card = s5pv210_setup_sdhci_cfg_card;
>>> +}
>>> +#else
>>> +static inline void s5pv210_default_sdhci3(void) { }
>>> +#endif /* CONFIG_S3C_DEV_HSMMC3 */
>> This could be simplified by putting the #ifdef inside the function.
> Yeah, you're right..but used same style with others in this file.
> ...so will modify it as your comment with others soon.
Hmm yes, I guess it's just a matter of personal taste.
--
Maurus Cuelenaere
next prev parent reply other threads:[~2010-07-04 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 0:07 [PATCH v2] Add support HSMMC on Samsung SMDKV210 Kukjin Kim
2010-07-03 0:07 ` [PATCH v2 1/2] ARM: SAMSUNG: Add device definition for HSMMC3 Kukjin Kim
2010-07-03 0:17 ` Maurus Cuelenaere
2010-07-03 1:21 ` Kukjin Kim
2010-07-04 9:22 ` Maurus Cuelenaere [this message]
2010-07-03 0:07 ` [PATCH v2 2/2] ARM: S5PV210: Add support HSMMC on SMDKV210 Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3052F3.4080208@gmail.com \
--to=mcuelenaere@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).