From: michael.williamson@criticallink.com (Michael Williamson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] davinci: Add MityDSP-L138/MityARM-1808 SOM support
Date: Mon, 19 Jul 2010 07:43:33 -0400 [thread overview]
Message-ID: <4C443A65.4010105@criticallink.com> (raw)
In-Reply-To: <1279324167.4526.85.camel@Joe-Laptop.home>
On 7/16/2010 7:49 PM, Joe Perches wrote:
> On Fri, 2010-07-16 at 10:00 -0400, Michael Williamson wrote:
>
>> +static __init void mityomapl138_setup_lcd(void)
>> +{
>>
> []
>
>> + pr_warning("mityomapl138_init: unknown LCD type : %s\n",
>> + peripheral_config.LCDConfig.PanelName);
>>
> I think you'd be better off actually using the actual
> function name rather than the caller name
>
Absolutely. Didn't catch those when shuffling around during cleanup /
etc.
I will clean these up and resubmit.
Thank you for the feedback.
[Message resent due to bad client configuration].
-Mike
prev parent reply other threads:[~2010-07-19 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 14:00 [PATCH] davinci: Add MityDSP-L138/MityARM-1808 SOM support Michael Williamson
2010-07-16 23:49 ` Joe Perches
2010-07-18 17:29 ` Mike Williamson
2010-07-19 6:35 ` Nori, Sekhar
2010-07-19 11:43 ` Michael Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C443A65.4010105@criticallink.com \
--to=michael.williamson@criticallink.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox