From: c.aeschlimann@acn-group.ch (Christophe Aeschlimann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] davinci: Add MityDSP-L138/MityARM-1808 SOM support
Date: Mon, 19 Jul 2010 16:22:43 +0200 [thread overview]
Message-ID: <4C445FB3.5050901@acn-group.ch> (raw)
In-Reply-To: <4C44515A.4030003@criticallink.com>
Hi,
Nice to see a new board based on the OMAP-L138.
A small comment below.
On 19.07.2010 15:21, Michael Williamson wrote:
[...]
> +static struct davinci_i2c_platform_data mityomap_i2c_0_pdata = {
> + .bus_freq = 100, /* kHz */
> + .bus_delay = 0, /* usec */
> +};
> +
> +/* TPS65070 voltage regulator support */
The comment doesn't match what _you are_ supporting.
> +
> +/* 1.2V Core */
> +struct regulator_consumer_supply tps65023_dcdc1_consumers[] = {
> + {
> + .supply = "cvdd",
> + },
> +};
> +
> +/* 1.8V */
> +struct regulator_consumer_supply tps65023_dcdc2_consumers[] = {
> + {
> + .supply = "usb0_vdda18",
> + },
> + {
> + .supply = "usb1_vdda18",
> + },
> + {
> + .supply = "ddr_dvdd18",
> + },
> + {
> + .supply = "sata_vddr",
> + },
> +};
> +
[...]
Regards,
--
Christophe Aeschlimann
Embedded Software Engineer
Advanced Communications Networks S.A.
Rue du Puits-Godet 8a
2000 Neuch?tel, Switzerland
T?l. +41 32 724 74 31
c.aeschlimann at acn-group.ch
next prev parent reply other threads:[~2010-07-19 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C44515A.4030003@criticallink.com>
2010-07-19 14:20 ` [PATCH v2] davinci: Add MityDSP-L138/MityARM-1808 SOM support Christophe Aeschlimann
2010-07-19 14:22 ` Christophe Aeschlimann [this message]
2010-07-19 19:36 ` Russell King - ARM Linux
2010-07-19 20:24 ` Michael Williamson
2010-07-19 13:35 Michael Williamson
2010-07-19 15:58 ` Joe Perches
2010-07-19 16:26 ` Michael Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C445FB3.5050901@acn-group.ch \
--to=c.aeschlimann@acn-group.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).