From: adrian.hunter@nokia.com (Adrian Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: failure of block read wait for long time
Date: Tue, 27 Jul 2010 16:22:13 +0300 [thread overview]
Message-ID: <4C4EDD85.5060606@nokia.com> (raw)
In-Reply-To: <1280230066-27612-1-git-send-email-s-ghorai@ti.com>
Sukumar Ghorai wrote:
> multi-block read failure retries in single block read one by one. It continues
> retry of subsequent blocks, even after failure. Application will not be able
> to decode the interleave data (even if few single block read success).
> This patch fixes this problem by returning at the first failure instead of
> waiting for long duration.
How can you know what sectors are important to the upper layers?
>
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
> drivers/mmc/card/block.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index cb9fbc8..cfb0827 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -419,7 +419,6 @@ static int mmc_blk_issue_rq(struct mmc_queue *mq, struct request *req)
> spin_lock_irq(&md->lock);
> ret = __blk_end_request(req, -EIO, brq.data.blksz);
> spin_unlock_irq(&md->lock);
> - continue;
> }
> goto cmd_err;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-07-27 13:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 11:27 [PATCH] mmc: failure of block read wait for long time Sukumar Ghorai
2010-07-27 13:22 ` Adrian Hunter [this message]
2010-07-27 13:32 ` Ghorai, Sukumar
2010-07-28 8:41 ` Adrian Hunter
2010-09-10 11:30 ` Ghorai, Sukumar
2010-09-10 11:43 ` Adrian Hunter
2010-09-10 11:48 ` Ghorai, Sukumar
2010-09-10 13:02 ` Adrian Hunter
2010-09-14 5:15 ` Ghorai, Sukumar
2010-09-20 7:54 ` Adrian Hunter
2010-09-20 8:57 ` Ghorai, Sukumar
2010-09-20 11:49 ` Adrian Hunter
2010-09-20 12:37 ` Ghorai, Sukumar
2010-09-20 13:09 ` Adrian Hunter
2010-09-20 13:25 ` Ghorai, Sukumar
2010-09-20 13:37 ` Russell King - ARM Linux
2010-09-22 5:32 ` Ghorai, Sukumar
2010-09-22 12:43 ` Chris Ball
2010-09-22 12:51 ` Ghorai, Sukumar
2010-09-24 14:35 ` Ghorai, Sukumar
2010-09-28 15:03 ` Ghorai, Sukumar
2010-09-28 18:32 ` Adrian Hunter
2010-09-28 18:59 ` Ghorai, Sukumar
2010-09-28 20:05 ` Adrian Hunter
2010-09-29 5:59 ` Ghorai, Sukumar
2010-08-27 20:59 ` Chris Ball
2010-08-30 19:09 ` Ghorai, Sukumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4EDD85.5060606@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).