From: michael.williamson@criticallink.com (Michael Williamson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] davinci: Add MityDSP-L138/MityARM-1808 SOM support
Date: Wed, 28 Jul 2010 12:02:26 -0400 [thread overview]
Message-ID: <4C505492.3060404@criticallink.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59301E7D0AF64@dbde02.ent.ti.com>
On 7/26/2010 5:29 AM, Nori, Sekhar wrote:
>
>
>> +
>> +static struct davinci_i2c_platform_data mityomap_i2c_0_pdata = {
>> + .bus_freq = 100, /* kHz */
>> + .bus_delay = 0, /* usec */
>> +};
> This is exactly the pdata that davinci I2C driver uses by default,
> so you can save a few bytes and a few lines of code by passing NULL
> pdata.
>
> [...]
>
So I tried your suggestion and passed NULL as the pdata argument, e.g.,
...
ret = da8xx_register_i2c(0, NULL);
...
and the kernel locks up during initialization. Did I not understand
what you were suggesting? I will back this suggestion out until I get a chance
to hunt down the problem. I see no other boards initialize the i2c this
way (they explicitly provide a structure).
Thanks.
-Mike
prev parent reply other threads:[~2010-07-28 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 14:10 [PATCH v3] davinci: Add MityDSP-L138/MityARM-1808 SOM support Michael Williamson
2010-07-26 9:29 ` Nori, Sekhar
2010-07-26 12:49 ` Michael Williamson
2010-08-05 19:01 ` Kevin Hilman
2010-08-05 19:39 ` Michael Williamson
2010-08-05 20:01 ` Ben Gardiner
2010-08-05 20:13 ` Michael Williamson
2010-08-10 14:29 ` Kevin Hilman
2010-08-10 15:13 ` Michael Williamson
2010-08-10 15:34 ` Kevin Hilman
2010-07-28 16:02 ` Michael Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C505492.3060404@criticallink.com \
--to=michael.williamson@criticallink.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).