public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: henne@nachtwindheim.de (Henrik Kretzschmar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video/w100fb: ignore void return value / fix build failure
Date: Wed, 28 Jul 2010 21:02:08 +0200	[thread overview]
Message-ID: <4C507EB0.8050208@nachtwindheim.de> (raw)
In-Reply-To: <201007282029.52989.PeterHuewe@gmx.de>

Am 28.07.2010 20:29, schrieb Peter H?we:
> From: Peter Huewe <peterhuewe@gmx.de>
> 
> This patch fixes a build failure [1] (error: void value not ignored as
> it ought to be) by removing an assignment of a void return value.
> The functionality of the code is not changed.
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Ached-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> ---
> KernelVersion: linux-next-20100728
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980912/
> 
>  drivers/video/w100fb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
> index e66b8b1..d8b12c3 100644
> --- a/drivers/video/w100fb.c
> +++ b/drivers/video/w100fb.c
> @@ -858,9 +858,9 @@ unsigned long w100fb_gpio_read(int port)
>  void w100fb_gpio_write(int port, unsigned long value)
>  {
>  	if (port==W100_GPIO_PORT_A)
> -		value = writel(value, remapped_regs + mmGPIO_DATA);
> +		writel(value, remapped_regs + mmGPIO_DATA);
>  	else
> -		value = writel(value, remapped_regs + mmGPIO_DATA2);
> +		writel(value, remapped_regs + mmGPIO_DATA2);
>  }
>  EXPORT_SYMBOL(w100fb_gpio_read);
>  EXPORT_SYMBOL(w100fb_gpio_write);

      reply	other threads:[~2010-07-28 19:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 18:29 [PATCH] video/w100fb: ignore void return value / fix build failure Peter Hüwe
2010-07-28 19:02 ` Henrik Kretzschmar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C507EB0.8050208@nachtwindheim.de \
    --to=henne@nachtwindheim.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox