From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] imxfb: add pwmr controlled backlight support
Date: Thu, 29 Jul 2010 10:49:58 +0200 [thread overview]
Message-ID: <4C5140B6.6030703@eukrea.com> (raw)
In-Reply-To: <20100729051647.GA11268@pengutronix.de>
Hi Uwe,
Le 29/07/2010 07:16, Uwe Kleine-K?nig a ?crit :
>> Signed-off-by: Eric B?nard<eric@eukrea.com>
>> ---
>> v2 : updated to use backlight infrastructure
> this should have a dependency on CONFIG_BACKLIGHT_CLASS_DEVICE. As
> Sascha already took your patch you can just try to build mx27_defconfig
> on his for-rmk branch :-|
>
> Instead of a dependency I would prefer to have imxfb usable without
> CONFIG_BACKLIGHT_CLASS_DEVICE. From a quick look there are drivers that
> have that. (I checked drivers/video/sa1100fb.c +
> drivers/video/backlight/locomolcd.c.)
>
I've just sent a patch which fixes this build failure with mx27_defconfig.
When CONFIG_BACKLIGHT_CLASS_DEVICE is not selected, the driver is now as
it was before my patch.
I'll try to put the backligh things in a driver into backlight directory
when I find time, which will remove the #ifdef
Also, I confirm the patch you sent for
arch/arm/plat-mxc/include/mach/gpio.h is necessary to compile a kernel
using mx27_defconfig .
Thanks,
Eric
next prev parent reply other threads:[~2010-07-29 8:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 13:09 [PATCH 1/3] eukrea_mbimxsd: factorize motherboard support Eric Bénard
2010-07-16 13:09 ` [PATCH 2/3] imx25: fix low level debug Eric Bénard
2010-07-16 13:09 ` [PATCH 3/3] imxfb: add pwmr controlled backlight support Eric Bénard
2010-07-29 5:16 ` Uwe Kleine-König
2010-07-29 8:42 ` [PATCH] video/imxfb.c: allow usage without BACKLIGHT_CLASS_DEVICE Eric Bénard
2010-07-29 9:11 ` Uwe Kleine-König
2010-07-29 9:47 ` [PATCH v2] " Eric Bénard
2010-07-29 12:45 ` Uwe Kleine-König
2010-07-29 13:03 ` Eric Bénard
2010-07-29 13:03 ` [PATCH v3] " Eric Bénard
2010-07-29 13:23 ` Sergei Shtylyov
2010-07-29 13:33 ` Eric Bénard
2010-07-29 14:17 ` [PATCH v4] " Eric Bénard
2010-07-29 15:01 ` Uwe Kleine-König
2010-08-02 7:39 ` [PATCH] " Uwe Kleine-König
2010-07-29 13:37 ` [PATCH v3] " Lothar Waßmann
2010-07-29 8:49 ` Eric Bénard [this message]
2010-07-22 15:51 ` [PATCH 1/3] eukrea_mbimxsd: factorize motherboard support Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5140B6.6030703@eukrea.com \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).