From: lilja.magnus@gmail.com (Magnus Lilja)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] SDMA support for i.MX
Date: Mon, 09 Aug 2010 20:38:14 +0200 [thread overview]
Message-ID: <4C604B16.7000309@gmail.com> (raw)
In-Reply-To: <1281344743-2029-1-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
On 2010-08-09 11:05, Sascha Hauer wrote:
> Hi all,
>
> Ever wondered what's hidden behind the tons of SDMA/iapi stuff in the
> Freescale kernel? It's a nice and convenient to use DMA engine. The
> following patches add support for it.
Nice!
> git://git.pengutronix.de/git/imx/sdma-firmware.git
>
> As the layout of the firmware is not given by fsl but by me it should
> be part of the review.
I don't have any comments on the layout but some general comments on files in sdma-firmware.git:
Some files are missing copyright and license information.
Shouldn't the gen_one() function do a free(name) also when everything is successfull? I.e. before return 0.
Also, in case of errors after line 67, fclose(f) should be called.
Regards, Magnus
prev parent reply other threads:[~2010-08-09 18:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 9:05 [RFC] SDMA support for i.MX Sascha Hauer
2010-08-09 9:05 ` [PATCH 1/8] ARM i.MX dma: implement wrapper for dma functions Sascha Hauer
2010-08-09 18:43 ` Magnus Lilja
2010-08-09 22:45 ` Linus Walleij
2010-08-10 12:34 ` Sascha Hauer
2010-08-09 9:05 ` [PATCH 2/8] ARM i.MX dma-mx1-mx2: use wrapper Sascha Hauer
2010-08-09 18:51 ` Magnus Lilja
2010-08-09 21:42 ` Sascha Hauer
2010-08-09 9:05 ` [PATCH 3/8] mxcmmc: use new dma api Sascha Hauer
2010-08-09 9:05 ` [PATCH 4/8] ARM i.MX: add SDMA driver Sascha Hauer
2010-08-09 19:04 ` Magnus Lilja
2010-08-10 7:15 ` Sascha Hauer
2010-08-10 9:20 ` Detlev Zundel
2010-08-10 13:46 ` Timur Tabi
2010-08-10 14:03 ` Lothar Waßmann
2010-08-10 14:08 ` Tabi Timur-B04825
2010-08-10 14:19 ` Detlev Zundel
2010-08-10 19:08 ` Uwe Kleine-König
2010-08-09 9:05 ` [PATCH 5/8] ARM i.MX3: Add sdma device Sascha Hauer
2010-08-09 9:05 ` [PATCH 6/8] ARM i.MX3: add dma request defines Sascha Hauer
2010-08-09 13:53 ` Uwe Kleine-König
2010-08-09 9:05 ` [PATCH 7/8] ARM i.MX3: add dma request resources to ssi/sdhc devices Sascha Hauer
2010-08-09 9:05 ` [PATCH 8/8] ASoC i.MX: switch to new DMA api Sascha Hauer
2010-08-10 13:21 ` Mark Brown
2010-08-09 18:38 ` Magnus Lilja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C604B16.7000309@gmail.com \
--to=lilja.magnus@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).