* [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig
@ 2010-08-13 8:15 Kukjin Kim
2010-08-13 8:39 ` Uwe Kleine-König
2010-08-13 9:57 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Kukjin Kim @ 2010-08-13 8:15 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes on following build warnings.
warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which
has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)
warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>
---
arch/arm/mach-s3c2440/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
index cd8e7de..f60a370 100644
--- a/arch/arm/mach-s3c2440/Kconfig
+++ b/arch/arm/mach-s3c2440/Kconfig
@@ -30,7 +30,7 @@ config CPU_S3C2442
config CPU_S3C244X
bool
- depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
+ depends on (CPU_S3C2440 || CPU_S3C2442)
help
Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
@@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
config S3C2440_DMA
bool
- depends on ARCH_S3C2410 && CPU_S3C24405B
+ depends on (ARCH_S3C2410 || CPU_S3C24405B)
help
Support for S3C2440 specific DMA code5A
--
1.6.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig
2010-08-13 8:15 [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig Kukjin Kim
@ 2010-08-13 8:39 ` Uwe Kleine-König
2010-08-13 9:54 ` Kukjin Kim
2010-08-13 9:57 ` Sergei Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2010-08-13 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 13, 2010 at 05:15:07PM +0900, Kukjin Kim wrote:
> This patch fixes on following build warnings.
>
> warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which
> has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)
> warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
> CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)
>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> ---
> arch/arm/mach-s3c2440/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
> index cd8e7de..f60a370 100644
> --- a/arch/arm/mach-s3c2440/Kconfig
> +++ b/arch/arm/mach-s3c2440/Kconfig
> @@ -30,7 +30,7 @@ config CPU_S3C2442
>
> config CPU_S3C244X
> bool
> - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
> + depends on (CPU_S3C2440 || CPU_S3C2442)
> help
> Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
>
> @@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
>
> config S3C2440_DMA
> bool
> - depends on ARCH_S3C2410 && CPU_S3C24405B
> + depends on (ARCH_S3C2410 || CPU_S3C24405B)
> help
> Support for S3C2440 specific DMA code5A
all parenthesis in your +lines are superflous.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig
2010-08-13 8:39 ` Uwe Kleine-König
@ 2010-08-13 9:54 ` Kukjin Kim
0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2010-08-13 9:54 UTC (permalink / raw)
To: linux-arm-kernel
Uwe Kleine-K?nig wrote:
>
> On Fri, Aug 13, 2010 at 05:15:07PM +0900, Kukjin Kim wrote:
> > This patch fixes on following build warnings.
> >
> > warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects
> S3C2440_DMA which
> > has unmet direct dependencies (ARCH_S3C2410 &&
> CPU_S3C24405B)
> > warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 &&
> ARCH_S3C2410) selects
> > CPU_S3C244X which has unmet direct dependencies
> (!ARCH_S3C2410)
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > ---
> > arch/arm/mach-s3c2440/Kconfig | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-s3c2440/Kconfig
b/arch/arm/mach-s3c2440/Kconfig
> > index cd8e7de..f60a370 100644
> > --- a/arch/arm/mach-s3c2440/Kconfig
> > +++ b/arch/arm/mach-s3c2440/Kconfig
> > @@ -30,7 +30,7 @@ config CPU_S3C2442
> >
> > config CPU_S3C244X
> > bool
> > - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
> > + depends on (CPU_S3C2440 || CPU_S3C2442)
> > help
> > Support for S3C2440 and S3C2442 Samsung Mobile CPU based
> systems.
> >
> > @@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
> >
> > config S3C2440_DMA
> > bool
> > - depends on ARCH_S3C2410 && CPU_S3C24405B
> > + depends on (ARCH_S3C2410 || CPU_S3C24405B)
> > help
> > Support for S3C2440 specific DMA code5A
> all parenthesis in your +lines are superflous.
>
Yeah, you're right.
Fixed. Thanks. :-)
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig
2010-08-13 8:15 [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig Kukjin Kim
2010-08-13 8:39 ` Uwe Kleine-König
@ 2010-08-13 9:57 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2010-08-13 9:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Kukjin Kim wrote:
> This patch fixes on following build warnings.
> warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which
> has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)
> warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects
> CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> ---
> arch/arm/mach-s3c2440/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
> index cd8e7de..f60a370 100644
> --- a/arch/arm/mach-s3c2440/Kconfig
> +++ b/arch/arm/mach-s3c2440/Kconfig
> @@ -30,7 +30,7 @@ config CPU_S3C2442
>
> config CPU_S3C244X
> bool
> - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
> + depends on (CPU_S3C2440 || CPU_S3C2442)
Parens not necessary...
> help
> Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
>
> @@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
>
> config S3C2440_DMA
> bool
> - depends on ARCH_S3C2410 && CPU_S3C24405B
> + depends on (ARCH_S3C2410 || CPU_S3C24405B)
Same comment here...
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-13 9:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-13 8:15 [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig Kukjin Kim
2010-08-13 8:39 ` Uwe Kleine-König
2010-08-13 9:54 ` Kukjin Kim
2010-08-13 9:57 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox