[PATCH 0/2] s3c: mach-real6410 missing fixes

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Darius Augulis]

Two patches adding fixes that where in v2 of my
previous mach-real6410 patch series. These fixes are:
 * coding style errors reported by checkpatch.pl
 * irq flag in dm9000 pdata

---

Darius Augulis (2):
      s3c: mach-real6410: fix coding style errors
      s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to dm9000


 arch/arm/mach-s3c64xx/mach-real6410.c |  104 +++++++++++++++++----------------
 1 files changed, 52 insertions(+), 52 deletions(-)

-- 

[PATCH 1/2] s3c: mach-real6410: fix coding style errors

[Darius Augulis]

Fix errors reported by checkpatch.pl script

Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
---
 arch/arm/mach-s3c64xx/mach-real6410.c |  104 +++++++++++++++++----------------
 1 files changed, 52 insertions(+), 52 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/mach-real6410.c b/arch/arm/mach-s3c64xx/mach-real6410.c
index 5c07d01..9f79e6b 100644
--- a/arch/arm/mach-s3c64xx/mach-real6410.c
+++ b/arch/arm/mach-s3c64xx/mach-real6410.c
@@ -30,73 +30,73 @@
 #include <plat/devs.h>
 #include <plat/regs-serial.h>
 
-#define UCON S3C2410_UCON_DEFAULT | S3C2410_UCON_UCLK
-#define ULCON S3C2410_LCON_CS8 | S3C2410_LCON_PNONE | S3C2410_LCON_STOPB
-#define UFCON S3C2410_UFCON_RXTRIG8 | S3C2410_UFCON_FIFOMODE
+#define UCON (S3C2410_UCON_DEFAULT | S3C2410_UCON_UCLK)
+#define ULCON (S3C2410_LCON_CS8 | S3C2410_LCON_PNONE | S3C2410_LCON_STOPB)
+#define UFCON (S3C2410_UFCON_RXTRIG8 | S3C2410_UFCON_FIFOMODE)
 
 static struct s3c2410_uartcfg real6410_uartcfgs[] __initdata = {
 	[0] = {
-		.hwport	     = 0,
-		.flags	     = 0,
-		.ucon	     = UCON,
-		.ulcon	     = ULCON,
-		.ufcon	     = UFCON,
+		.hwport	= 0,
+		.flags	= 0,
+		.ucon	= UCON,
+		.ulcon	= ULCON,
+		.ufcon	= UFCON,
 	},
 	[1] = {
-		.hwport	     = 1,
-		.flags	     = 0,
-		.ucon	     = UCON,
-		.ulcon	     = ULCON,
-		.ufcon	     = UFCON,
+		.hwport	= 1,
+		.flags	= 0,
+		.ucon	= UCON,
+		.ulcon	= ULCON,
+		.ufcon	= UFCON,
 	},
 	[2] = {
-		.hwport	     = 2,
-		.flags	     = 0,
-		.ucon	     = UCON,
-		.ulcon	     = ULCON,
-		.ufcon	     = UFCON,
+		.hwport	= 2,
+		.flags	= 0,
+		.ucon	= UCON,
+		.ulcon	= ULCON,
+		.ufcon	= UFCON,
 	},
 	[3] = {
-		.hwport	     = 3,
-		.flags	     = 0,
-		.ucon	     = UCON,
-		.ulcon	     = ULCON,
-		.ufcon	     = UFCON,
+		.hwport	= 3,
+		.flags	= 0,
+		.ucon	= UCON,
+		.ulcon	= ULCON,
+		.ufcon	= UFCON,
 	},
 };
 
 /* DM9000AEP 10/100 ethernet controller */
 
 static struct resource real6410_dm9k_resource[] = {
-        [0] = {
-                .start = S3C64XX_PA_XM0CSN1,
-                .end   = S3C64XX_PA_XM0CSN1 + 1,
-                .flags = IORESOURCE_MEM
-        },
-        [1] = {
-                .start = S3C64XX_PA_XM0CSN1 + 4,
-                .end   = S3C64XX_PA_XM0CSN1 + 5,
-                .flags = IORESOURCE_MEM
-        },
-        [2] = {
-                .start = S3C_EINT(7),
-                .end   = S3C_EINT(7),
-                .flags = IORESOURCE_IRQ,
-        }
+	[0] = {
+		.start	= S3C64XX_PA_XM0CSN1,
+		.end	= S3C64XX_PA_XM0CSN1 + 1,
+		.flags	= IORESOURCE_MEM
+	},
+	[1] = {
+		.start	= S3C64XX_PA_XM0CSN1 + 4,
+		.end	= S3C64XX_PA_XM0CSN1 + 5,
+		.flags	= IORESOURCE_MEM
+	},
+	[2] = {
+		.start	= S3C_EINT(7),
+		.end	= S3C_EINT(7),
+		.flags	= IORESOURCE_IRQ,
+	}
 };
 
 static struct dm9000_plat_data real6410_dm9k_pdata = {
-        .flags          = (DM9000_PLATF_16BITONLY | DM9000_PLATF_NO_EEPROM),
+	.flags		= (DM9000_PLATF_16BITONLY | DM9000_PLATF_NO_EEPROM),
 };
 
 static struct platform_device real6410_device_eth = {
-        .name           = "dm9000",
-        .id             = -1,
-        .num_resources  = ARRAY_SIZE(real6410_dm9k_resource),
-        .resource       = real6410_dm9k_resource,
-        .dev            = {
-                .platform_data  = &real6410_dm9k_pdata,
-        },
+	.name		= "dm9000",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(real6410_dm9k_resource),
+	.resource	= real6410_dm9k_resource,
+	.dev		= {
+		.platform_data	= &real6410_dm9k_pdata,
+	},
 };
 
 static struct platform_device *real6410_devices[] __initdata = {
@@ -129,12 +129,12 @@ static void __init real6410_machine_init(void)
 	/* set timing for nCS1 suitable for ethernet chip */
 
 	__raw_writel((0 << S3C64XX_SROM_BCX__PMC__SHIFT) |
-			(6 << S3C64XX_SROM_BCX__TACP__SHIFT) |
-			(4 << S3C64XX_SROM_BCX__TCAH__SHIFT) |
-			(1 << S3C64XX_SROM_BCX__TCOH__SHIFT) |
-			(13 << S3C64XX_SROM_BCX__TACC__SHIFT) |
-			(4 << S3C64XX_SROM_BCX__TCOS__SHIFT) |
-			(0 << S3C64XX_SROM_BCX__TACS__SHIFT), S3C64XX_SROM_BC1);
+		(6 << S3C64XX_SROM_BCX__TACP__SHIFT) |
+		(4 << S3C64XX_SROM_BCX__TCAH__SHIFT) |
+		(1 << S3C64XX_SROM_BCX__TCOH__SHIFT) |
+		(13 << S3C64XX_SROM_BCX__TACC__SHIFT) |
+		(4 << S3C64XX_SROM_BCX__TCOS__SHIFT) |
+		(0 << S3C64XX_SROM_BCX__TACS__SHIFT), S3C64XX_SROM_BC1);
 
 	platform_add_devices(real6410_devices, ARRAY_SIZE(real6410_devices));
 }

[PATCH 2/2] s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to dm9000

[Darius Augulis]

Add IORESOURCE_IRQ_HIGHLEVEL irq flag to dm9000 driver
platform data in board mach-real6410.

Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
---
 arch/arm/mach-s3c64xx/mach-real6410.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/mach-real6410.c b/arch/arm/mach-s3c64xx/mach-real6410.c
index 9f79e6b..e130379 100644
--- a/arch/arm/mach-s3c64xx/mach-real6410.c
+++ b/arch/arm/mach-s3c64xx/mach-real6410.c
@@ -81,7 +81,7 @@ static struct resource real6410_dm9k_resource[] = {
 	[2] = {
 		.start	= S3C_EINT(7),
 		.end	= S3C_EINT(7),
-		.flags	= IORESOURCE_IRQ,
+		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL
 	}
 };
 

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Darius Augulis]

Hi Ben, Kukjin,

please add these patches to your tree, they contain necessary fixes for 
mach-real6410.

Darius.


On 08/16/2010 08:43 PM, Darius Augulis wrote:
> Two patches adding fixes that where in v2 of my
> previous mach-real6410 patch series. These fixes are:
>   * coding style errors reported by checkpatch.pl
>   * irq flag in dm9000 pdata
>
> ---
>
> Darius Augulis (2):
>        s3c: mach-real6410: fix coding style errors
>        s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to dm9000
>
>
>   arch/arm/mach-s3c64xx/mach-real6410.c |  104 +++++++++++++++++----------------
>   1 files changed, 52 insertions(+), 52 deletions(-)
>

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Kukjin Kim]

Darius Augulis wrote:
> 
> Hi Ben, Kukjin,
> 
Hi Darius,

> please add these patches to your tree, they contain necessary fixes for
> mach-real6410.
> 
Looks good your patches.

But I think, this should be sent to upstream through Ben's tree.

If Ben has no time to handle this, I will do it through my tree.

> Darius.
> 
> 
> On 08/16/2010 08:43 PM, Darius Augulis wrote:
> > Two patches adding fixes that where in v2 of my
> > previous mach-real6410 patch series. These fixes are:
> >   * coding style errors reported by checkpatch.pl
> >   * irq flag in dm9000 pdata
> >
> > ---
> >
> > Darius Augulis (2):
> >        s3c: mach-real6410: fix coding style errors
> >        s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to
> dm9000
> >
> >
> >   arch/arm/mach-s3c64xx/mach-real6410.c |  104
+++++++++++++++++----------
> ------
> >   1 files changed, 52 insertions(+), 52 deletions(-)
> >


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Darius Augulis]

Hi,

On 08/27/2010 09:38 AM, Kukjin Kim wrote:
> Darius Augulis wrote:
>>
>> Hi Ben, Kukjin,
>>
> Hi Darius,
>
>> please add these patches to your tree, they contain necessary fixes for
>> mach-real6410.
>>
> Looks good your patches.
>
> But I think, this should be sent to upstream through Ben's tree.
>
> If Ben has no time to handle this, I will do it through my tree.

it seems he hasn't. please pick up these two patches and older one, with 
fixup of device name of samsung serial. it hangs already for a long time 
without any comment.

Darius.

>
>> Darius.
>>
>>
>> On 08/16/2010 08:43 PM, Darius Augulis wrote:
>>> Two patches adding fixes that where in v2 of my
>>> previous mach-real6410 patch series. These fixes are:
>>>    * coding style errors reported by checkpatch.pl
>>>    * irq flag in dm9000 pdata
>>>
>>> ---
>>>
>>> Darius Augulis (2):
>>>         s3c: mach-real6410: fix coding style errors
>>>         s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to
>> dm9000
>>>
>>>
>>>    arch/arm/mach-s3c64xx/mach-real6410.c |  104
> +++++++++++++++++----------
>> ------
>>>    1 files changed, 52 insertions(+), 52 deletions(-)
>>>
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim<kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Kukjin Kim]

Darius Augulis wrote:
> 
> Hi,
> 
Hi ;-)

> On 08/27/2010 09:38 AM, Kukjin Kim wrote:
> > Darius Augulis wrote:
> >>
> >> Hi Ben, Kukjin,
> >>
> > Hi Darius,
> >
> >> please add these patches to your tree, they contain necessary fixes for
> >> mach-real6410.
> >>
> > Looks good your patches.
> >
> > But I think, this should be sent to upstream through Ben's tree.
> >
> > If Ben has no time to handle this, I will do it through my tree.
> 
> it seems he hasn't. please pick up these two patches and older one, with
> fixup of device name of samsung serial. it hangs already for a long time
> without any comment.

I have a question about dm9000 on your real6410.

The smdkv210 use it also, but need to some modify dm9000 driver for use it.
Is there no problem on your board?

And please refer to my other comment about device name of Samsung serial.

Ben,
I will apply Darius' fixing CodingStyle patch.
If any problems, please let me know.

> 
> Darius.
> 
> >
> >> Darius.
> >>
> >>
> >> On 08/16/2010 08:43 PM, Darius Augulis wrote:
> >>> Two patches adding fixes that where in v2 of my
> >>> previous mach-real6410 patch series. These fixes are:
> >>>    * coding style errors reported by checkpatch.pl
> >>>    * irq flag in dm9000 pdata
> >>>
> >>> ---
> >>>
> >>> Darius Augulis (2):
> >>>         s3c: mach-real6410: fix coding style errors
> >>>         s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to
> >> dm9000
> >>>
> >>>
> >>>    arch/arm/mach-s3c64xx/mach-real6410.c |  104
> > +++++++++++++++++----------
> >> ------
> >>>    1 files changed, 52 insertions(+), 52 deletions(-)
> >>>
> >
> >


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Darius Augulis]

On Wed, Sep 1, 2010 at 4:50 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Darius Augulis wrote:
>>
>> Hi,
>>
> Hi ;-)
>
>> On 08/27/2010 09:38 AM, Kukjin Kim wrote:
>> > Darius Augulis wrote:
>> >>
>> >> Hi Ben, Kukjin,
>> >>
>> > Hi Darius,
>> >
>> >> please add these patches to your tree, they contain necessary fixes for
>> >> mach-real6410.
>> >>
>> > Looks good your patches.
>> >
>> > But I think, this should be sent to upstream through Ben's tree.
>> >
>> > If Ben has no time to handle this, I will do it through my tree.
>>
>> it seems he hasn't. please pick up these two patches and older one, with
>> fixup of device name of samsung serial. it hangs already for a long time
>> without any comment.
>
> I have a question about dm9000 on your real6410.
>
> The smdkv210 use it also, but need to some modify dm9000 driver for use it.
> Is there no problem on your board?

this patch is not driver fix. dm9000 on real6410 is working well and
tested several times.
so, please add this patch to your tree too. if you found some bug in
dm9000 driver or if you need new features please provide new patch.

>
> And please refer to my other comment about device name of Samsung serial.
>
> Ben,
> I will apply Darius' fixing CodingStyle patch.
> If any problems, please let me know.
>
>>
>> Darius.
>>
>> >
>> >> Darius.
>> >>
>> >>
>> >> On 08/16/2010 08:43 PM, Darius Augulis wrote:
>> >>> Two patches adding fixes that where in v2 of my
>> >>> previous mach-real6410 patch series. These fixes are:
>> >>> ? ?* coding style errors reported by checkpatch.pl
>> >>> ? ?* irq flag in dm9000 pdata
>> >>>
>> >>> ---
>> >>>
>> >>> Darius Augulis (2):
>> >>> ? ? ? ? s3c: mach-real6410: fix coding style errors
>> >>> ? ? ? ? s3c: mach-real6410: add IORESOURCE_IRQ_HIGHLEVEL flag to
>> >> dm9000
>> >>>
>> >>>
>> >>> ? ?arch/arm/mach-s3c64xx/mach-real6410.c | ?104
>> > +++++++++++++++++----------
>> >> ------
>> >>> ? ?1 files changed, 52 insertions(+), 52 deletions(-)
>> >>>
>> >
>> >
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>

[PATCH 0/2] s3c: mach-real6410 missing fixes

[Kukjin Kim]

Darius Augulis wrote:
> 
> On Wed, Sep 1, 2010 at 4:50 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Darius Augulis wrote:
> >>
> >> Hi,
> >>
> > Hi ;-)
> >
> >> On 08/27/2010 09:38 AM, Kukjin Kim wrote:
> >> > Darius Augulis wrote:
> >> >>
> >> >> Hi Ben, Kukjin,
> >> >>
> >> > Hi Darius,
> >> >
> >> >> please add these patches to your tree, they contain necessary fixes
for
> >> >> mach-real6410.
> >> >>
> >> > Looks good your patches.
> >> >
> >> > But I think, this should be sent to upstream through Ben's tree.
> >> >
> >> > If Ben has no time to handle this, I will do it through my tree.
> >>
> >> it seems he hasn't. please pick up these two patches and older one,
with
> >> fixup of device name of samsung serial. it hangs already for a long
time
> >> without any comment.
> >
> > I have a question about dm9000 on your real6410.
> >
> > The smdkv210 use it also, but need to some modify dm9000 driver for use
it.
> > Is there no problem on your board?
> 
> this patch is not driver fix. dm9000 on real6410 is working well and
> tested several times.
> so, please add this patch to your tree too. if you found some bug in
> dm9000 driver or if you need new features please provide new patch.
> 
Yeah I know, yours is not driver fix.
I did just wonder working of dm9000.

Because there was some problem on my board as following.
The dm9000 Phy enable was required at that time.
Ethernet did not work without dm9000 Phy enable.

But couldn't find the root cause and because that is not general in my
thinking, not submitted.

> >
> > And please refer to my other comment about device name of Samsung
serial.
> >
> > Ben,
> > I will apply Darius' fixing CodingStyle patch.
> > If any problems, please let me know.
> >
> >>

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.