linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: michael.williamson@criticallink.com (Michael Williamson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] davinci: Add I2C0 devices to MityDSP-L138/MityARM-1808 platform
Date: Sun, 05 Sep 2010 08:02:52 -0400	[thread overview]
Message-ID: <4C8386EC.50002@criticallink.com> (raw)
In-Reply-To: <4C837195.2040100@mvista.com>

On 09/05/2010 06:31 AM, Sergei Shtylyov wrote:
> Hello.
> 
> On 04-09-2010 20:11, Michael Williamson wrote:
> 
>> This patch adds the i2c0 bus and attached devices to the MityDSP-L138
>> and MityARM-1808 davinci SoM.  Included is a TPS65023 voltage regulator
>> needed for power management and a small 24c02 EPROM that contains
>> factory configuration data.
> 
>> Signed-off-by: Michael Williamson<michael.williamson@criticallink.com>
> [...]
>> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c
>> b/arch/arm/mach-davinci/board-mityomapl138.c
>> index 7146916..03820ce 100644
>> --- a/arch/arm/mach-davinci/board-mityomapl138.c
>> +++ b/arch/arm/mach-davinci/board-mityomapl138.c
> [...]
>> @@ -25,6 +27,141 @@
> [...]
>> +struct regulator_init_data tps65023_regulator_data[] = {
>> +    /* dcdc1 */
>> +    {
>> +        .constraints = {
>> +            .min_uV = 1150000,
>> +            .max_uV = 1350000,
>> +            .valid_ops_mask = (REGULATOR_CHANGE_VOLTAGE |
>> +                REGULATOR_CHANGE_STATUS),
> 
>    Would look better if you aligned it. And parens are useless here.
> 

I'll clean it up, but I pretty much lifted it from board-da850-evm.c. 
The next time someone's in there, I suppose it should also be addressed.

Thanks for the comments.

      reply	other threads:[~2010-09-05 12:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04 16:11 [PATCH] davinci: Add I2C0 devices to MityDSP-L138/MityARM-1808 platform Michael Williamson
2010-09-05 10:31 ` Sergei Shtylyov
2010-09-05 12:02   ` Michael Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8386EC.50002@criticallink.com \
    --to=michael.williamson@criticallink.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).