From: ben@simtec.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] s3cmci: minor fixups
Date: Wed, 08 Sep 2010 00:15:40 +0100 [thread overview]
Message-ID: <4C86C79C.1010205@simtec.co.uk> (raw)
In-Reply-To: <1283872596-687-1-git-send-email-anarsoul@gmail.com>
On 07/09/10 16:16, Vasily Khoruzhick wrote:
> - It's not necessary to start DMA op manually, as we have
> autostart feature enabled
> - Restore prescaler before DMA operation, otherwise it
> takes ages to complete DMA op.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> drivers/mmc/host/s3cmci.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 2e16e0a..5d1a8ed 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -1106,6 +1106,8 @@ static int s3cmci_prepare_dma(struct s3cmci_host *host, struct mmc_data *data)
> sg_dma_address(&data->sg[i]),
> sg_dma_len(&data->sg[i]));
>
> + /* Restore prescaler value */
> + writel(host->prescaler, host->base + S3C2410_SDIPRE);
> res = s3c2410_dma_enqueue(host->dma, host,
> sg_dma_address(&data->sg[i]),
> sg_dma_len(&data->sg[i]));
> @@ -1116,8 +1118,6 @@ static int s3cmci_prepare_dma(struct s3cmci_host *host, struct mmc_data *data)
> }
> }
>
> - s3c2410_dma_ctrl(host->dma, S3C2410_DMAOP_START);
> -
> return 0;
> }
looks ok to me.
Acked-By: Ben Dooks <ben-linux@fluff.org>
next prev parent reply other threads:[~2010-09-07 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 15:09 [PATCH 0/2] s3c24xx: fix s3cmci DMA support Vasily Khoruzhick
2010-09-07 15:16 ` [PATCH 2/2] s3cmci: minor fixups Vasily Khoruzhick
2010-09-07 23:15 ` Ben Dooks [this message]
2010-09-07 23:14 ` [PATCH 0/2] s3c24xx: fix s3cmci DMA support Ben Dooks
2010-09-07 23:23 ` [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature Vasily Khoruzhick
2010-09-07 23:37 ` Ben Dooks
2010-09-08 6:27 ` Vasily Khoruzhick
-- strict thread matches above, loose matches on Subject: below --
2010-08-18 15:04 [PATCH 0/2] s3c24xx: fix DMA support for MCI Vasily Khoruzhick
2010-08-18 15:04 ` [PATCH 2/2] s3cmci: minor fixups Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C86C79C.1010205@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).