* [PATCH RESEND] ARM: s3c2440: fix boot failure introduced by recent changes in gpiolib
@ 2010-09-03 18:18 Abdoulaye Walsimou Gaye
2010-09-07 23:31 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: Abdoulaye Walsimou Gaye @ 2010-09-03 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Recent changes in s3c gpio break mini2440 board and may be others.
The problem is that mach-mini2440.c: mini2440_init()
(where we call s3c_gpio_setpull()) is called before s3c2440.c: s3c2440_init()
(where we initialize s3c24xx_gpiocfg_default.set_pull function pointer).
This causes dereferencing of NULL pointer at boot time and a kernel panic.
Signed-off-by: Abdoulaye Walsimou Gaye <awg@embtoolkit.org>
---
arch/arm/plat-s3c24xx/gpiolib.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-s3c24xx/gpiolib.c b/arch/arm/plat-s3c24xx/gpiolib.c
index 4c0896f..ae9d3c2 100644
--- a/arch/arm/plat-s3c24xx/gpiolib.c
+++ b/arch/arm/plat-s3c24xx/gpiolib.c
@@ -87,6 +87,8 @@ static struct s3c_gpio_cfg s3c24xx_gpiocfg_banka = {
struct s3c_gpio_cfg s3c24xx_gpiocfg_default = {
.set_config = s3c_gpio_setcfg_s3c24xx,
.get_config = s3c_gpio_getcfg_s3c24xx,
+ .set_pull = s3c_gpio_setpull_1up,
+ .get_pull = s3c_gpio_getpull_1up,
};
struct s3c_gpio_chip s3c24xx_gpios[] = {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RESEND] ARM: s3c2440: fix boot failure introduced by recent changes in gpiolib
2010-09-03 18:18 [PATCH RESEND] ARM: s3c2440: fix boot failure introduced by recent changes in gpiolib Abdoulaye Walsimou Gaye
@ 2010-09-07 23:31 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2010-09-07 23:31 UTC (permalink / raw)
To: linux-arm-kernel
On 03/09/10 19:18, Abdoulaye Walsimou Gaye wrote:
> Recent changes in s3c gpio break mini2440 board and may be others.
> The problem is that mach-mini2440.c: mini2440_init()
> (where we call s3c_gpio_setpull()) is called before s3c2440.c: s3c2440_init()
> (where we initialize s3c24xx_gpiocfg_default.set_pull function pointer).
> This causes dereferencing of NULL pointer at boot time and a kernel panic.
>
> Signed-off-by: Abdoulaye Walsimou Gaye <awg@embtoolkit.org>
ok, i'll think over this. it is probably the right thing to do.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-07 23:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 18:18 [PATCH RESEND] ARM: s3c2440: fix boot failure introduced by recent changes in gpiolib Abdoulaye Walsimou Gaye
2010-09-07 23:31 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).