From: adrian.hunter@nokia.com (Adrian Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMC: move regulator handling closer to core v3
Date: Thu, 09 Sep 2010 15:56:31 +0300 [thread overview]
Message-ID: <4C88D97F.2080804@nokia.com> (raw)
In-Reply-To: <20100909093810.GA1988@rakim.wolfsonmicro.main>
Mark Brown wrote:
> On Thu, Sep 09, 2010 at 09:01:27AM +0300, Adrian Hunter wrote:
>
>> As an aside, I would like to enhance the regulator framework to
>> enable boards to hook their code directly into the regulator.
>
> What do you mean when you say that you would like boards to "hook
> directly into the regulator" - what do you want to be able to do?
> Is this the notifiers? Do you need more of them?
There would need to be notifiers before and after any change to the
voltage. However the notifiers would have to be set up before or
during regulator initialisation because initialisation already can
change the voltage e.g. in set_machine_constraints.
>
>> Arguably this is essential to allow pbias configuration (without
>> which the board may be damaged) so that regulator_enable/disable
>> can be used independently of the board, or for example to allow
>
> I can't parse this at all I'm afraid. Could you be more specific about
> what you mean by using enable and disable independantly of the board -
> clearly the consumer drivers are already able to be board independant?
For OMAP3 (and OMAP2 in some cases) the 1st SD/SDIO/MMC controller
can operate at either 1.8V or 3V, however at 3V the board must apply
voltage level shifting (PBIAS configuation). Currently the
level-shifting is done by board code that must be called before and
after the voltage changes. The omap_hsmmc driver calls the board
code via callbacks in platform data (.before_set_reg and
.after_set_reg).
>
>> the regulator core to turn the regulator on/off at initialisation.
>
> The regulator core already supports enabling or disabling regulators
> from the machine constraints which I *think* is what you're looking for
> but since I can't follow what you're saying above I'm not sure.
Yes that is what I would like, but it won't work at present because
the core does not do the PBIAS configuration.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-09-09 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 9:05 [PATCH] MMC: move regulator handling closer to core v3 Linus Walleij
2010-09-08 22:51 ` Andrew Morton
2010-09-09 6:01 ` Adrian Hunter
2010-09-09 9:38 ` Mark Brown
2010-09-09 12:56 ` Adrian Hunter [this message]
2010-09-09 13:12 ` Mark Brown
2010-09-10 10:05 ` Adrian Hunter
2010-09-10 10:37 ` Mark Brown
2010-09-09 7:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C88D97F.2080804@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).