From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91sam9g45: fix i2c bus speed
Date: Wed, 22 Sep 2010 18:06:06 +0200 [thread overview]
Message-ID: <4C9A296E.6060503@atmel.com> (raw)
In-Reply-To: <1285147886-17100-1-git-send-email-jacmet@sunsite.dk>
Le 22/09/2010 11:31, Peter Korsgaard :
> Use a correct udelay value to get bus speed around 100KHz. The udelay
> value was most likely copied from the older devices, but the 9g45
> is signicantly faster (400MHz, DDR, ..), so a udelay of 2 gives a
> bus speed of around 190KHz, which is too fast for some devices.
> A udelay value of 5 gives a bus speed of around 90KHz here.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/mach-at91/at91sam9g45_devices.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
> index 5e71ccd..1276bab 100644
> --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> +++ b/arch/arm/mach-at91/at91sam9g45_devices.c
> @@ -426,7 +426,7 @@ static struct i2c_gpio_platform_data pdata_i2c0 = {
> .sda_is_open_drain = 1,
> .scl_pin = AT91_PIN_PA21,
> .scl_is_open_drain = 1,
> - .udelay = 2, /* ~100 kHz */
> + .udelay = 5, /* ~100 kHz */
> };
>
> static struct platform_device at91sam9g45_twi0_device = {
> @@ -440,7 +440,7 @@ static struct i2c_gpio_platform_data pdata_i2c1 = {
> .sda_is_open_drain = 1,
> .scl_pin = AT91_PIN_PB11,
> .scl_is_open_drain = 1,
> - .udelay = 2, /* ~100 kHz */
> + .udelay = 5, /* ~100 kHz */
> };
>
> static struct platform_device at91sam9g45_twi1_device = {
--
Nicolas Ferre
next prev parent reply other threads:[~2010-09-22 16:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 9:31 [PATCH] at91sam9g45: fix i2c bus speed Peter Korsgaard
2010-09-22 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 11:08 ` Peter Korsgaard
2010-09-22 14:34 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 14:54 ` Wolfgang Wegner
2010-09-22 16:09 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 15:18 ` Peter Korsgaard
2010-09-22 16:05 ` Nicolas Ferre
2010-09-22 16:10 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 16:06 ` Nicolas Ferre [this message]
2010-09-23 8:18 ` Nicolas Ferre
2010-09-23 9:22 ` Peter Korsgaard
2010-09-23 9:31 ` Russell King - ARM Linux
2010-09-23 10:09 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 10:24 ` Peter Korsgaard
2010-09-23 10:21 ` Peter Korsgaard
2010-09-23 10:36 ` Russell King - ARM Linux
2010-09-23 10:54 ` Peter Korsgaard
2010-09-23 11:16 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 11:32 ` Peter Korsgaard
2010-09-23 12:00 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 11:07 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9A296E.6060503@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).