From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions
Date: Mon, 27 Sep 2010 02:39:44 +0200 [thread overview]
Message-ID: <4C9FE7D0.8030804@metafoo.de> (raw)
In-Reply-To: <4C9FE1B6.2060005@fluff.org>
Ben Dooks wrote:
> On 24/09/10 19:24, Lars-Peter Clausen wrote:
>> The gta02 header file still uses the old S3C2410_GPJx defines instead of the
>> S3C2410_GPJ(x) macro. Since the S3C2410_GPJx defines have already been removed
>> this causes a build failure.
>> This patches fixes the issue by doing a s,S3C2410_GPJ([\d]+),S3C2410_GPJ(\1),g
>> on the file.
>
> Is this currently causing a build error? If so, please add the snippet
> of the build log. Otherwise it'll get queued for the next merge.
CC sound/soc/s3c24xx/neo1973_gta02_wm8753.o
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'lm4853_set_spk':
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: 'S3C2440_GPJ2' undeclared (first
use in this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: (Each undeclared identifier is
reported only once
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:244: error: for each function it appears in.)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'lm4853_event':
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:265: error: 'S3C2440_GPJ1' undeclared (first
use in this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:265: error: 'value' undeclared (first use in
this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'neo1973_gta02_init':
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:458: error: 'S3C2440_GPJ2' undeclared (first
use in this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:464: error: 'GTA02_GPIO_AMP_HP_IN'
undeclared (first use in this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:470: error: 'S3C2440_GPJ1' undeclared (first
use in this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c: In function 'neo1973_gta02_exit':
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:498: error: 'S3C2440_GPJ2' undeclared (first
use in this function)
sound/soc/s3c24xx/neo1973_gta02_wm8753.c:499: error: 'S3C2440_GPJ1' undeclared (first
use in this function)
prev parent reply other threads:[~2010-09-27 0:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 18:24 [PATCH] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Lars-Peter Clausen
2010-09-27 0:13 ` Ben Dooks
2010-09-27 0:39 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9FE7D0.8030804@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).