linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ulpi: add i.MX25 & 35 internal PHY ID
Date: Tue, 05 Oct 2010 17:12:07 +0200	[thread overview]
Message-ID: <4CAB4047.1090401@eukrea.com> (raw)
In-Reply-To: <4CAB2145.8050605@compulab.co.il>

Hi Igor,

Le 05/10/2010 14:59, Igor Grinberg a ?crit :
> This driver is still in development stage and is not fully functional,
> so I'd like to keep the table and ID info printing, but I really don't like
> trivial IDs, like that of Eric.
>
> How about something like the attached patch?
>
> Eric, can you test if it works for you?
>
> If it's good, I can send a prettier version of it for review and merging.
>
ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
mxc-ehci mxc-ehci.0: initializing i.MX USB Controller
ULPI transceiver vendor/product ID 0x0000/0x0000
ULPI integrity check: failed!

In fact, that's my fault, the internal PHY is not ULPI but UTMI so we 
should not use these functions here and it was working until now by 
chance as there are dedicated registers to control the internal PHY 
which are initialized with the right values as a default.

Sorry for the noise and forget my patch which is wrong, I'll rework the 
platform data as in the present case we should not provide use ulpi when 
using the internal PHY.

Eric

  reply	other threads:[~2010-10-05 15:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 12:23 [PATCH] ulpi: add i.MX25 & 35 internal PHY ID Eric Bénard
2010-10-04 14:54 ` Sergei Shtylyov
2010-10-04 15:15   ` Igor Grinberg
2010-10-05  5:42     ` Daniel Mack
2010-10-05 12:59       ` Igor Grinberg
2010-10-05 15:12         ` Eric Bénard [this message]
2010-10-05 15:42           ` Igor Grinberg
2010-10-05 15:50             ` Eric Bénard
2010-10-05 16:51               ` [PATCH] cpuimx25 & cpuimx35: fix OTG port registration in host mode Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAB4047.1090401@eukrea.com \
    --to=eric@eukrea.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).