From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] omap4: pandaboard: Fix the init if CONFIG_MMC_OMAP_HS is not set
Date: Thu, 07 Oct 2010 15:15:23 +0400 [thread overview]
Message-ID: <4CADABCB.6060906@ru.mvista.com> (raw)
In-Reply-To: <1286400020-1010-3-git-send-email-x0132446@ti.com>
Hello.
On 07-10-2010 1:20, David Anders wrote:
> Avoid possible crash if CONFIG_MMC_OMAP_HS is not set.
> Signed-off-by: David Anders<x0132446@ti.com>
> Signed-off-by: Anand Gadiyar<gadiyar@ti.com>
[...]
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 093d13b..697c0bd 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -85,7 +85,14 @@ static int omap4_twl6030_hsmmc_late_init(struct device *dev)
>
> static __init void omap4_twl6030_hsmmc_set_late_init(struct device *dev)
> {
> - struct omap_mmc_platform_data *pdata = dev->platform_data;
> + struct omap_mmc_platform_data *pdata;
> +
> + /* dev can be null if CONFIG_MMC_OMAP_HS is not set */
s/null/NULL/?
> + if (!dev) {
> + pr_err("Failed omap4_twl6030_hsmmc_set_late_init\n");
pr_err("Failed %s\n", __func__);
WBR, Sergei
next prev parent reply other threads:[~2010-10-07 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 21:20 [PATCH 0/4] omap4: pandaboard: machine cleanups David Anders
2010-10-06 21:20 ` [PATCH 1/4] omap4: pandaboard: remove unused hsmmc definition David Anders
2010-10-06 21:20 ` [PATCH 2/4] omap4: pandaboard: Fix the init if CONFIG_MMC_OMAP_HS is not set David Anders
2010-10-07 11:15 ` Sergei Shtylyov [this message]
2010-10-06 21:20 ` [PATCH 3/4] omap4: pandaboard: Adding card detect support for MMC1 David Anders
2010-10-06 21:20 ` [PATCH 4/4] omap4: pandaboard: enable the ehci port on pandaboard David Anders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CADABCB.6060906@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).