* [PATCH 2/4] mx31_3ds: Fix the logic for detecting the debug board
@ 2010-10-25 14:54 Rogerio Pimentel
2010-10-26 2:14 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Rogerio Pimentel @ 2010-10-25 14:54 UTC (permalink / raw)
To: linux-arm-kernel
The function mxc_expio_init returns 0 on success, so fix the logic for
printing the error case.
Also fixed the wording on the error message.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com>
---
arch/arm/mach-mx3/mach-mx31_3ds.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-mx3/mach-mx31_3ds.c
b/arch/arm/mach-mx3/mach-mx31_3ds.c
index bc21efc..005c0b2 100644
--- a/arch/arm/mach-mx3/mach-mx31_3ds.c
+++ b/arch/arm/mach-mx3/mach-mx31_3ds.c
@@ -251,9 +251,9 @@ static void __init mxc_board_init(void)
mx31_3ds_usbotg_init();
mxc_register_device(&mxc_otg_udc_device, &usbotg_pdata);
- if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
- printk(KERN_WARNING "Init of the debugboard failed, all "
- "devices on the board are unusable.\n");
+ if (mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
+ printk(KERN_WARNING "Init of the debug board failed, all "
+ "devices on the debug board are unusable.\n");
}
static void __init mx31_3ds_timer_init(void)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/4] mx31_3ds: Fix the logic for detecting the debug board
2010-10-25 14:54 [PATCH 2/4] mx31_3ds: Fix the logic for detecting the debug board Rogerio Pimentel
@ 2010-10-26 2:14 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2010-10-26 2:14 UTC (permalink / raw)
To: linux-arm-kernel
Acked-by: Jason Wang <jason77.wang@gmail.com>
Rogerio Pimentel wrote:
> The function mxc_expio_init returns 0 on success, so fix the logic for
> printing the error case.
> Also fixed the wording on the error message.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com>
>
> ---
> arch/arm/mach-mx3/mach-mx31_3ds.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-mx3/mach-mx31_3ds.c
> b/arch/arm/mach-mx3/mach-mx31_3ds.c
> index bc21efc..005c0b2 100644
> --- a/arch/arm/mach-mx3/mach-mx31_3ds.c
> +++ b/arch/arm/mach-mx3/mach-mx31_3ds.c
> @@ -251,9 +251,9 @@ static void __init mxc_board_init(void)
> mx31_3ds_usbotg_init();
> mxc_register_device(&mxc_otg_udc_device, &usbotg_pdata);
>
> - if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
> - printk(KERN_WARNING "Init of the debugboard failed, all "
> - "devices on the board are unusable.\n");
> + if (mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
> + printk(KERN_WARNING "Init of the debug board failed, all "
> + "devices on the debug board are unusable.\n");
> }
>
> static void __init mx31_3ds_timer_init(void)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-26 2:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 14:54 [PATCH 2/4] mx31_3ds: Fix the logic for detecting the debug board Rogerio Pimentel
2010-10-26 2:14 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).