From: cyril@ti.com (Cyril Chemparathy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 01/12] misc: add driver for sequencer serial port
Date: Thu, 28 Oct 2010 12:09:35 -0400 [thread overview]
Message-ID: <4CC9A03F.80401@ti.com> (raw)
In-Reply-To: <AANLkTi=rDep3jkp2QAjVsgjZ7JQ0ysnse4TARv29fyHm@mail.gmail.com>
On 10/28/2010 11:49 AM, Linus Walleij wrote:
> 2010/10/26 Cyril Chemparathy <cyril@ti.com>:
>
>> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
>> device. It has a built-in programmable execution engine that can be programmed
>> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
>>
>> This patch adds a driver for this controller device. The driver does not
>> expose a user-land interface. Protocol drivers built on top of this layer are
>> expected to remain in-kernel.
>
> Why is this thing in drivers/misc?
>
> drivers/mfd is IMHO the apropriate place for a driver like this, and
> the subdrivers should be migrated to use mfd cells and platform
> drivers for the subdevices.
>
> All functions and abstractions you create here look suspiciously
> lot like other MFD devices.
>
> But please, beat me up if I'm wrong!
Alan had raised the same concern earlier, and my response was:
> Unlike MFDs, this device doesn't have cells with differing
> functionality. Instead it has functionally identical ports that can
> operate in a variety of modes. That said, does this still fit in with
> other MFD drivers? If so, I don't see a problem with moving it there.
I don't see a problem with moving this into MFD, but this won't be able
to use any of the functionality provided by mfd-core.
Thanks
Cyril.
next prev parent reply other threads:[~2010-10-28 16:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 20:18 [PATCH v4 00/12] tnetv107x ssp driver stack Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
2010-10-28 15:49 ` Linus Walleij
2010-10-28 16:09 ` Cyril Chemparathy [this message]
2010-10-28 18:14 ` Linus Walleij
2010-10-26 20:18 ` [PATCH v4 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy
2010-11-03 2:15 ` David Brownell
2010-11-03 10:18 ` Linus Walleij
2010-11-03 12:35 ` David Brownell
2010-11-03 16:24 ` Linus Walleij
2010-11-10 4:45 ` Grant Likely
2010-11-10 6:16 ` David Brownell
2010-11-10 6:23 ` Grant Likely
2010-11-10 14:34 ` Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
2010-10-26 20:18 ` [PATCH v4 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC9A03F.80401@ti.com \
--to=cyril@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).