public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: omar.ramirez@ti.com (Omar Ramirez Luna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] omap:mailbox-resolve multiple receiver problem
Date: Thu, 28 Oct 2010 17:18:20 -0500	[thread overview]
Message-ID: <4CC9F6AC.9030308@ti.com> (raw)
In-Reply-To: <1287108808-32119-6-git-send-email-h-kanigeri2@ti.com>

On 10/14/2010 9:13 PM, Kanigeri, Hari wrote:
> OMAP4 shares one interrupt line for all the mailbox instances.
> The ISR is handling only the mailbox instance that was registered last.

This shouldn't be needed, request_irq is being called with IRQF_SHARED 
flag and different device ids, so if a message arrives it fires an 
interrupt handler for each of the callers to request_irq and since the 
device id is actually a pointer to a mbox struct, the different users 
can be detected and signaled without looping through the "mboxes" list.

Also using "mboxes" list, will try to check for all registered mailboxes 
during probe, which might not be the same as the actual users (the ones 
that have called omap_mbox_get) and then unnecesary check their irq 
statuses if an interrupt arrives.

I think this patch can be dropped.

Regards,

Omar

  reply	other threads:[~2010-10-28 22:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15  2:13 [PATCH 0/7] omap:mailbox-enhancements and fixes Hari Kanigeri
2010-10-15  2:13 ` [PATCH 1/7] mailbox: change full flag per mailbox queue instead of global Hari Kanigeri
2010-10-15  2:13 ` [PATCH 2/7] omap:mailbox: fix rx interrupt disable in omap4 Hari Kanigeri
2010-10-15  2:13 ` [PATCH 3/7] omap:mailbox-fix checkpatch warnings Hari Kanigeri
2010-10-15  2:13 ` [PATCH 4/7] omap:mailbox-send message in process context Hari Kanigeri
2010-10-21 19:03   ` Sapiens, Rene
2010-10-21 20:49     ` Hari Kanigeri
2010-10-21 22:30       ` Sapiens, Rene
2010-10-15  2:13 ` [PATCH 5/7] omap:mailbox-resolve multiple receiver problem Hari Kanigeri
2010-10-28 22:18   ` Omar Ramirez Luna [this message]
2010-10-29 12:10     ` Hari Kanigeri
2010-10-15  2:13 ` [PATCH 6/7] omap:mailbox-add notification support for multiple readers Hari Kanigeri
2010-10-28 20:57   ` Omar Ramirez Luna
2010-10-29 12:05     ` Hari Kanigeri
2010-10-15  2:13 ` [PATCH 7/7] omap:clocks44x-add dummy clock for mailbox Hari Kanigeri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC9F6AC.9030308@ti.com \
    --to=omar.ramirez@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox