From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.
Date: Wed, 03 Nov 2010 10:15:31 +0100 [thread overview]
Message-ID: <4CD12833.8060204@eukrea.com> (raw)
In-Reply-To: <1288736227-800-2-git-send-email-Dinh.Nguyen@freescale.com>
Hi Dinh,
Le 02/11/2010 23:17, Dinh.Nguyen at freescale.com a ?crit :
> From: Dinh Nguyen<Dinh.Nguyen@freescale.com>
>
> Add mx53 support to cpu.c and mm.c.
>
> Signed-off by: Dinh Nguyen<Dinh.Nguyen@freescale.com>
> static void query_silicon_parameter(void)
> {
> - void __iomem *rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> + void __iomem *rom;
> u32 rev;
>
> + if (cpu_is_mx51())
> + rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> + else if (cpu_is_mx53())
> + rom = ioremap(MX53_IROM_BASE_ADDR, MX53_IROM_SIZE);
> +
isn't the correct way to get the silicon revision to read the "Product
Revision register" and "Silicon Revision register" of the IIM and not from the
internal ROM ? (page 41-11 of the i.MX51 reference manual).
Eric
next prev parent reply other threads:[~2010-11-03 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 22:17 [PATCH 1/2] ARM: imx: Add core definitions for MX53 Dinh.Nguyen at freescale.com
2010-11-02 22:17 ` [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions Dinh.Nguyen at freescale.com
2010-11-02 22:21 ` Russell King - ARM Linux
2010-11-03 9:15 ` Eric Bénard [this message]
2010-11-04 19:21 ` Nguyen Dinh-R00091
2010-11-04 20:30 ` Eric Bénard
2010-11-04 21:24 ` Nguyen Dinh-R00091
2010-11-04 21:30 ` Nguyen Dinh-R00091
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD12833.8060204@eukrea.com \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).