* ARM: fix compile warning in mm/init.c
@ 2010-11-12 6:19 Anand Gadiyar
2010-11-12 7:40 ` Uwe Kleine-König
2010-11-12 8:36 ` Russell King - ARM Linux
0 siblings, 2 replies; 6+ messages in thread
From: Anand Gadiyar @ 2010-11-12 6:19 UTC (permalink / raw)
To: linux-arm-kernel
Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
changed VMALLOC_END to be an explicit value. Before this, it was
relative to PAGE_OFFSET and therefore automatically upgraded to
unsigned long as PAGE_OFFSET was an unsigned long. This introduced
the following build warning. Fix this.
CC arch/arm/mm/init.o
arch/arm/mm/init.c: In function 'mem_init':
arch/arm/mm/init.c:606: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: Nicolas Pitre <nico@fluxnic.net>
---
arch/arm/mm/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: ehci/arch/arm/mm/init.c
===================================================================
--- ehci.orig/arch/arm/mm/init.c
+++ ehci/arch/arm/mm/init.c
@@ -593,7 +593,7 @@ void __init mem_init(void)
#ifdef CONFIG_MMU
MLM(CONSISTENT_BASE, CONSISTENT_END),
#endif
- MLM(VMALLOC_START, VMALLOC_END),
+ MLM(VMALLOC_START, (unsigned long)VMALLOC_END),
MLM(PAGE_OFFSET, (unsigned long)high_memory),
#ifdef CONFIG_HIGHMEM
MLM(PKMAP_BASE, (PKMAP_BASE) + (LAST_PKMAP) *
^ permalink raw reply [flat|nested] 6+ messages in thread
* ARM: fix compile warning in mm/init.c
2010-11-12 6:19 ARM: fix compile warning in mm/init.c Anand Gadiyar
@ 2010-11-12 7:40 ` Uwe Kleine-König
2010-11-12 8:22 ` Kyungmin Park
2010-11-12 8:36 ` Russell King - ARM Linux
1 sibling, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2010-11-12 7:40 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 12, 2010 at 11:49:13AM +0530, Anand Gadiyar wrote:
> Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
> changed VMALLOC_END to be an explicit value. Before this, it was
> relative to PAGE_OFFSET and therefore automatically upgraded to
> unsigned long as PAGE_OFFSET was an unsigned long. This introduced
> the following build warning. Fix this.
>
> CC arch/arm/mm/init.o
> arch/arm/mm/init.c: In function 'mem_init':
> arch/arm/mm/init.c:606: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> ---
> arch/arm/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: ehci/arch/arm/mm/init.c
> ===================================================================
> --- ehci.orig/arch/arm/mm/init.c
> +++ ehci/arch/arm/mm/init.c
> @@ -593,7 +593,7 @@ void __init mem_init(void)
> #ifdef CONFIG_MMU
> MLM(CONSISTENT_BASE, CONSISTENT_END),
> #endif
> - MLM(VMALLOC_START, VMALLOC_END),
> + MLM(VMALLOC_START, (unsigned long)VMALLOC_END),
I wonder if this is the only place where this is a problem. Maybe it's
better to make the defined value of all VMALLOC_END an unsigned long as
some already are?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* ARM: fix compile warning in mm/init.c
2010-11-12 7:40 ` Uwe Kleine-König
@ 2010-11-12 8:22 ` Kyungmin Park
0 siblings, 0 replies; 6+ messages in thread
From: Kyungmin Park @ 2010-11-12 8:22 UTC (permalink / raw)
To: linux-arm-kernel
2010/11/12 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> On Fri, Nov 12, 2010 at 11:49:13AM +0530, Anand Gadiyar wrote:
>> Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
>> changed VMALLOC_END to be an explicit value. Before this, it was
>> relative to PAGE_OFFSET and therefore automatically upgraded to
>> unsigned long as PAGE_OFFSET was an unsigned long. This introduced
>> the following build warning. Fix this.
>>
>> ? CC ? ? ?arch/arm/mm/init.o
>> arch/arm/mm/init.c: In function 'mem_init':
>> arch/arm/mm/init.c:606: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'
>>
>> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
>> Cc: Nicolas Pitre <nico@fluxnic.net>
>> ---
>> ?arch/arm/mm/init.c | ? ?2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: ehci/arch/arm/mm/init.c
>> ===================================================================
>> --- ehci.orig/arch/arm/mm/init.c
>> +++ ehci/arch/arm/mm/init.c
>> @@ -593,7 +593,7 @@ void __init mem_init(void)
>> ?#ifdef CONFIG_MMU
>> ? ? ? ? ? ? ? ? ? ? ? MLM(CONSISTENT_BASE, CONSISTENT_END),
>> ?#endif
>> - ? ? ? ? ? ? ? ? ? ? MLM(VMALLOC_START, VMALLOC_END),
>> + ? ? ? ? ? ? ? ? ? ? MLM(VMALLOC_START, (unsigned long)VMALLOC_END),
> I wonder if this is the only place where this is a problem. ?Maybe it's
> better to make the defined value of all VMALLOC_END an unsigned long as
> some already are?
Right, Samsung SoCs change it to UL to fix this issue.
Thank you,
Kyungmin Park
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | Uwe Kleine-K?nig ? ? ? ? ? ?|
> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* ARM: fix compile warning in mm/init.c
2010-11-12 6:19 ARM: fix compile warning in mm/init.c Anand Gadiyar
2010-11-12 7:40 ` Uwe Kleine-König
@ 2010-11-12 8:36 ` Russell King - ARM Linux
2010-11-12 8:49 ` Anand Gadiyar
1 sibling, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2010-11-12 8:36 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 12, 2010 at 11:49:13AM +0530, Anand Gadiyar wrote:
> Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
> changed VMALLOC_END to be an explicit value. Before this, it was
> relative to PAGE_OFFSET and therefore automatically upgraded to
> unsigned long as PAGE_OFFSET was an unsigned long. This introduced
> the following build warning. Fix this.
Please fix your definition of VMALLOC_END.
^ permalink raw reply [flat|nested] 6+ messages in thread
* ARM: fix compile warning in mm/init.c
2010-11-12 8:36 ` Russell King - ARM Linux
@ 2010-11-12 8:49 ` Anand Gadiyar
2010-11-12 8:51 ` Russell King - ARM Linux
0 siblings, 1 reply; 6+ messages in thread
From: Anand Gadiyar @ 2010-11-12 8:49 UTC (permalink / raw)
To: linux-arm-kernel
On 11/12/2010 2:06 PM, Russell King - ARM Linux wrote:
> On Fri, Nov 12, 2010 at 11:49:13AM +0530, Anand Gadiyar wrote:
>> Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
>> changed VMALLOC_END to be an explicit value. Before this, it was
>> relative to PAGE_OFFSET and therefore automatically upgraded to
>> unsigned long as PAGE_OFFSET was an unsigned long. This introduced
>> the following build warning. Fix this.
>
> Please fix your definition of VMALLOC_END.
Will do. Should I also fix up the other mach-* that were touched by this patch?
- Anand
^ permalink raw reply [flat|nested] 6+ messages in thread
* ARM: fix compile warning in mm/init.c
2010-11-12 8:49 ` Anand Gadiyar
@ 2010-11-12 8:51 ` Russell King - ARM Linux
0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2010-11-12 8:51 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 12, 2010 at 02:19:01PM +0530, Anand Gadiyar wrote:
> On 11/12/2010 2:06 PM, Russell King - ARM Linux wrote:
> > On Fri, Nov 12, 2010 at 11:49:13AM +0530, Anand Gadiyar wrote:
> >> Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
> >> changed VMALLOC_END to be an explicit value. Before this, it was
> >> relative to PAGE_OFFSET and therefore automatically upgraded to
> >> unsigned long as PAGE_OFFSET was an unsigned long. This introduced
> >> the following build warning. Fix this.
> >
> > Please fix your definition of VMALLOC_END.
>
> Will do. Should I also fix up the other mach-* that were touched by this patch?
That would be useful, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-12 8:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-12 6:19 ARM: fix compile warning in mm/init.c Anand Gadiyar
2010-11-12 7:40 ` Uwe Kleine-König
2010-11-12 8:22 ` Kyungmin Park
2010-11-12 8:36 ` Russell King - ARM Linux
2010-11-12 8:49 ` Anand Gadiyar
2010-11-12 8:51 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).