From: bengt.g.jonsson@stericsson.com (Bengt Jonsson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] regulators: Update of ab8500 driver
Date: Wed, 24 Nov 2010 13:11:29 +0100 [thread overview]
Message-ID: <4CED00F1.6050004@stericsson.com> (raw)
In-Reply-To: <20101124104851.GA24970@rakim.wolfsonmicro.main>
On 2010-11-24 11:48, Mark Brown wrote:
> On Wed, Nov 24, 2010 at 08:57:09AM +0100, Bengt Jonsson wrote:
>
>> Removing the macros is just my suggestion. The disadvantage I see
>> with macros is that I need to read both the macro and the listing to
>> see what it really does. On the other hand, macros are probably more
>
> A line of comment at the top of the macro table would probably address
> that?
I will make sure to have a comment at the top.
Still, I would like to provide a patch which removes the macros just to
show the difference. Then you can decide to drop it or propose another
change.
next prev parent reply other threads:[~2010-11-24 12:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 18:25 [PATCH 0/3] regulators: Update of ab8500 driver Bengt Jonsson
2010-11-23 18:25 ` [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration Bengt Jonsson
2010-11-23 18:30 ` Mark Brown
2010-11-24 8:24 ` Bengt Jonsson
2010-11-24 11:36 ` Mark Brown
2010-11-24 12:13 ` Bengt Jonsson
2010-11-23 18:25 ` [PATCH 2/3] regulators: Update of ab8500 driver Bengt Jonsson
2010-11-23 18:38 ` Mark Brown
2010-11-24 7:57 ` Bengt Jonsson
2010-11-24 10:48 ` Mark Brown
2010-11-24 12:11 ` Bengt Jonsson [this message]
2010-11-23 18:25 ` [PATCH 3/3] mach-ux500: Updated and added regulator board configuration in ab8500 Bengt Jonsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CED00F1.6050004@stericsson.com \
--to=bengt.g.jonsson@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).