From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix find_next_zero_bit and related assembly
Date: Wed, 24 Nov 2010 10:12:54 -0800 [thread overview]
Message-ID: <4CED55A6.5090608@codeaurora.org> (raw)
In-Reply-To: <201011231528.25668.jajones@nvidia.com>
On 11/23/2010 03:28 PM, James Jones wrote:
> On Tuesday 23 November 2010 13:26:47 Nicolas Pitre wrote:
>> On Thu, 11 Nov 2010, James Jones wrote:
>>> The find_next_bit, find_first_bit, find_next_zero_bit
>>> and find_first_zero_bit functions were not properly
>>> clamping to the maxbit argument at the bit level. They
>>> were instead only checking maxbit at the byte level.
>>> To fix this, add a compare and a conditional move
>>> instruction to the end of the common bit-within-the-
>>> byte code used by all the functions and be sure not to
>>> clobber the maxbit argument before it is used.
>>>
>>> Signed-off-by: James Jones <jajones@nvidia.com>
>>> Tested-by: Stephen Warren <swarren@nvidia.com>
>> Reviewed-by: Nicolas Pitre <nicolas.pitre@linaro.org>
>>
>> Please send to RMK's patch system.
> Thanks for the review. It's already in the patch system, but I updated the
> entry to include your reviewed-by line.
Should this be sent to the stable tree too?
next prev parent reply other threads:[~2010-11-24 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1289524615-22484-1-git-send-email-jajones@nvidia.com>
2010-11-23 21:26 ` [PATCH] ARM: Fix find_next_zero_bit and related assembly Nicolas Pitre
2010-11-23 23:28 ` James Jones
2010-11-24 18:12 ` Stephen Boyd [this message]
2010-11-24 19:00 ` Nicolas Pitre
2010-11-24 19:08 ` James Jones
2010-11-24 19:13 ` Nicolas Pitre
2010-11-24 19:15 ` Russell King - ARM Linux
2010-11-19 18:13 James Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CED55A6.5090608@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).