From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/4] ARM: Allow machines to override __delay()
Date: Wed, 08 Dec 2010 12:24:05 -0800 [thread overview]
Message-ID: <4CFFE965.30906@codeaurora.org> (raw)
In-Reply-To: <1291836162.12568.17.camel@c-dwalke-linux.qualcomm.com>
On 12/08/2010 11:22 AM, Daniel Walker wrote:
> On Tue, 2010-12-07 at 20:38 -0800, Stephen Boyd wrote:
>> +
>> +static void (*delay_fn)(unsigned long) = delay_loop;
>> +
>> +void set_delay_fn(void (*fn)(unsigned long))
>> +{
>> + delay_fn = fn;
>> +}
>> +
>> +/*
>> + * loops = usecs * HZ * loops_per_jiffy / 1000000
>> + */
>> +void __delay(unsigned long loops)
>> +{
>> + delay_fn(loops);
>> +}
>> EXPORT_SYMBOL(__delay);
> Didn't we already go over this part ? Why are aren't you putting these
> in a header file ?
Last time we saw that inlining set_delay_fn() actually increased the
text size of the kernel. I know it sounds wrong, but its probably due to
that compiler behavior Russell posted about last month on arm-lkml.
I'd like to see what Russell wants to do since so far he's been silent
on this whole series.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-08 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 4:38 [PATCHv3 0/4] ARM: Fixing udelay() for SMP and non-SMP systems Stephen Boyd
2010-12-08 4:38 ` [PATCHv3 1/4] ARM: Translate delay.S into (mostly) C Stephen Boyd
2010-12-08 4:38 ` [PATCHv3 2/4] ARM: Allow machines to override __delay() Stephen Boyd
2010-12-08 19:22 ` Daniel Walker
2010-12-08 20:24 ` Stephen Boyd [this message]
2010-12-08 20:26 ` Daniel Walker
2010-12-08 20:30 ` Stephen Boyd
2010-12-08 21:07 ` Daniel Walker
2010-12-08 4:38 ` [PATCHv3 3/4] ARM: Implement a timer based __delay() loop Stephen Boyd
2010-12-08 4:38 ` [PATCHv3 4/4] msm: timer: Migrate to timer based __delay() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFFE965.30906@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).