From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: V6 MPCore v6_dma_inv_range and v6_dma_flush_range RWFO fix
Date: Thu, 09 Dec 2010 14:07:17 -0800 [thread overview]
Message-ID: <4D015315.5070600@codeaurora.org> (raw)
In-Reply-To: <AANLkTi=g7eHv9=L8G9CphLLLp6n-e_quDbuSW1LeSEqK@mail.gmail.com>
On 12/09/2010 08:04 AM, Catalin Marinas wrote:
> On 24 November 2010 18:39, Valentine Barshak <vbarshak@mvista.com> wrote:
>> Updated according to the comments to avoid r/w outside the buffer and
>> used byte r/w for the possible unaligned data. Seems to work fine.
>>
>> Cache ownership must be acqired by reading/writing data from the
>> cache line to make cache operation have the desired effect on the
>> SMP MPCore CPU. However, the ownership is never aquired in the
>> v6_dma_inv_range function when cleaning the first line and
>> flushing the last one, in case the address is not aligned
>> to D_CACHE_LINE_SIZE boundary.
>> Fix this by reading/writing data if needed, before performing
>> cache operations.
>> While at it, fix v6_dma_flush_range to prevent RWFO outside
>> the buffer.
>>
>> Signed-off-by: Valentine Barshak <vbarshak@mvista.com>
>> Signed-off-by: George G. Davis <gdavis@mvista.com>
> I eventually found a bit of time to look at this. The patch looks fine to me:
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Is this also a stable candidate? At least it applies cleanly to .35
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-09 22:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 22:28 [PATCH] ARM: V6 MPCore v6_dma_inv_range RWFO fix Valentine Barshak
2010-11-23 22:42 ` Russell King - ARM Linux
2010-11-24 0:24 ` George G. Davis
2010-11-24 10:32 ` Catalin Marinas
2010-11-24 15:14 ` George G. Davis
2010-11-24 10:42 ` Catalin Marinas
2010-11-24 15:10 ` George G. Davis
2010-11-24 15:35 ` Catalin Marinas
2010-11-24 17:33 ` Russell King - ARM Linux
2010-11-24 17:46 ` Catalin Marinas
2010-11-24 18:01 ` Russell King - ARM Linux
2010-11-24 18:07 ` Catalin Marinas
2010-11-24 18:39 ` [PATCH] ARM: V6 MPCore v6_dma_inv_range and v6_dma_flush_range " Valentine Barshak
2010-12-08 10:25 ` Valentine Barshak
2010-12-09 16:04 ` Catalin Marinas
2010-12-09 17:04 ` Valentine Barshak
2010-12-09 22:07 ` Stephen Boyd [this message]
2010-12-10 5:44 ` George G. Davis
2010-12-10 5:26 ` George G. Davis
2010-12-10 9:50 ` Catalin Marinas
2010-12-10 12:29 ` Valentine Barshak
2010-12-10 16:49 ` George G. Davis
2010-11-29 15:28 ` Valentine Barshak
2010-11-24 17:40 ` [PATCH] ARM: V6 MPCore v6_dma_inv_range " Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D015315.5070600@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).