From: ext-srikar.1.bhavanarayana@nokia.com (Srikar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: rx51: Remove tvout code that plays with gpio 40
Date: Wed, 22 Dec 2010 13:55:38 +0200 [thread overview]
Message-ID: <4D11E73A.8070009@nokia.com> (raw)
In-Reply-To: <1293012004.6829.2.camel@tubuntu>
Good, Now GPIO40 now supports switch between Headset and TV Out.
Now updated ASoc Driver is already available in upstream kernel to
support the switching between Headset and TvOut ...
Srikar
On 12/22/2010 12:00 PM, Tomi Valkeinen wrote:
> On Tue, 2010-12-21 at 19:46 +0200, ext Jarkko Nikula wrote:
>> Commit 60d24ee "Added video data to support tvout on rx51" added code that
>> tries to assign gpio 40 as OMAP DSS reset_gpio for tvout. This is wrong
>> since this gpio has nothing to do with OMAP DSS but it is used to control
>> one switch that selects is the audio jack connected to tvout or audio
>> circuitry.
>>
>> This switch is already supported by the RX51 ASoC driver so there is no need
>> to control it elsewhere. Switch is contolled with ALSA control
>> 'Jack Function' and tvout can be selected with following example:
>>
>> amixer -D hw:0 set 'Jack Function' 'TV-OUT'
> Looks good. platform_enable/disable and reset_gpio fields should anyway
> be removed from the omap_dss_device struct, so this goes into right
> direction.
>
> Tony, can you take this patch also, as (I guess) it depends on the
> previous rx51 patches from Jarkko?
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
>
> Tomi
>
>
next prev parent reply other threads:[~2010-12-22 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 17:46 [PATCH] omap: rx51: Remove tvout code that plays with gpio 40 Jarkko Nikula
2010-12-22 10:00 ` Tomi Valkeinen
2010-12-22 11:55 ` Srikar [this message]
2010-12-22 18:57 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D11E73A.8070009@nokia.com \
--to=ext-srikar.1.bhavanarayana@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).