From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Mon, 3 Jan 2011 09:18:45 +0530 Subject: [PATCH V3 36/63] ST SPEAr : FSMC (Flexible Static Memory Controller) NOR interface driver In-Reply-To: References: <187ed7b3996c7f37ce782d847d3ecc761c3e52b8.1292833228.git.viresh.kumar@st.com> Message-ID: <4D21471D.60705@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Linus, On 12/26/2010 09:08 PM, Linus Walleij wrote: > 2010/12/20 Viresh Kumar : > (...) >> diff --git a/arch/arm/mach-spear13xx/fsmc-nor.c b/arch/arm/mach-spear13xx/fsmc-nor.c >> new file mode 100644 >> index 0000000..03234b6 >> --- /dev/null >> +++ b/arch/arm/mach-spear13xx/fsmc-nor.c > > What is this file doing in mach-spear13xx? Several other platforms > like U300 and Nomadik use the same NOR controller. > > This should be in drivers/mtd/* somewhere I believe? > >> @@ -0,0 +1,85 @@ >> +/* >> + * arch/arm/mach-spear13xx/fsmc-nor.c >> + * >> + * FSMC (Flexible Static Memory Controller) interface for NOR >> + * >> + * Copyright (C) 2010 ST Microelectronics >> + * Vipin Kumar >> + * >> + * This file is licensed under the terms of the GNU General Public >> + * License version 2. This program is licensed "as is" without any >> + * warranty of any kind, whether express or implied. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > Use as include file, get rid of plat/fsmc.h. > Extend that .h file with the stuff you need. > > We need to keep definitions for MTD NOR, NAND and OneNAND using FSMC > in this file so as to keep things simple. One header file is enough, and it's > very generic too, FSMC is not for plat-spear/* but also U300, Nomadik and > Ux500. > Yes i agree. I will remove patches related to fsmc from this patch series and will send them separately. -- viresh