From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'
Date: Tue, 04 Jan 2011 12:52:54 -0600 [thread overview]
Message-ID: <4D236C86.10703@ti.com> (raw)
In-Reply-To: <d7800f7a785b294a089ea8772607d232@mail.gmail.com>
Santosh Shilimkar had written, on 01/04/2011 12:50 PM, the following:
[..]
>>>> +static inline struct voltagedomain
>>> *omap_voltage_domain_lookup(char *name)
>>>> +{
>>>> + return NULL;
>>> the omap_voltage_domain_lookup uses ERR_PTR() for all return
>> values
>>> which are handled by the callers with IS_ERR()
>>>
>>> I think you should return ERR_PTR(-EINVAL)
>>>
>> The expected return value is pointer type and hence used
>> NULL.
>
> 'ERR_PTR(-EINVAL)' is also ok.
looking at the implementation (when CONFIG_PM is enabled),
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=blob;f=arch/arm/mach-omap2/voltage.c;h=ed6079c94c57bae30f599bbad5e25a38fc676fa8;hb=refs/heads/omap-for-linus#l1487
ERR_PTR(-EINVAL) looks more appropriate to me.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2011-01-04 18:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 18:26 [PATCH 0/5] omap2plus: Trivial build break fixes Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared Santosh Shilimkar
2011-01-04 18:49 ` Nishanth Menon
2011-01-04 18:51 ` Santosh Shilimkar
2011-01-04 18:56 ` Nishanth Menon
2011-01-04 18:46 ` [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Nishanth Menon
2011-01-04 18:48 ` Santosh Shilimkar
2011-01-04 18:50 ` Santosh Shilimkar
2011-01-04 18:52 ` Nishanth Menon [this message]
2011-01-04 18:43 ` [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Nishanth Menon
2011-01-04 18:46 ` Santosh Shilimkar
2011-01-04 18:41 ` [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Paul Walmsley
2011-01-04 18:43 ` Santosh Shilimkar
2011-01-05 0:32 ` Kevin Hilman
2011-01-05 8:18 ` Santosh Shilimkar
2011-01-04 18:43 ` [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Paul Walmsley
2011-01-04 18:45 ` Santosh Shilimkar
2011-01-05 0:37 ` [PATCH 0/5] omap2plus: Trivial build break fixes Kevin Hilman
2011-01-05 10:58 ` Santosh Shilimkar
2011-01-05 17:20 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D236C86.10703@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).