From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] OMAP: TWL: sparse fixes
Date: Wed, 05 Jan 2011 07:32:58 -0600 [thread overview]
Message-ID: <4D24730A.3050905@ti.com> (raw)
In-Reply-To: <20110105002549.GA1445@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote, on 01/04/2011 06:25 PM:
> On Tue, Jan 04, 2011 at 02:37:23PM -0600, Nishanth Menon wrote:
>> hmm.. minor nit (with codesourcery 2010.09-50 - 4.5.1):
>> rm arch/arm/mach-omap2/*.o;make C=1 arch/arm/mach-omap2/ 2>Kerr;make C=2
>> arch/arm/mach-omap2/ 2>Kerr1;diff Kerr Kerr1
>> [..]
>> 1,4d0
>> < arch/arm/mach-omap2/mux.c: In function 'omap_mux_get_by_name':
>> < arch/arm/mach-omap2/mux.c:163:17: warning: 'found_mode' may be used
>> uninitialized in this function
>> < arch/arm/mach-omap2/clkt_clksel.c: In function 'omap2_clksel_set_parent':
>> < arch/arm/mach-omap2/clkt_clksel.c:100:35: warning: 'max_clkr' may be
>> used uninitialized in this function
>>
>> Kinda interesting to note that C=2 does'nt list all potential gcc
>> warnings :( if one wanted a collated list of all warnings, rm .../*.o
>> helps I guess.
>
> C=2 only runs sparse - so if you're committing patches to fix sparse
> warnings, that's what you should be interested in.
>
> I'd suggest that fixing sparse warnings and GCC warnings in a single
> patch is probably not the best thing to do - GCC warnings are less
> subjective than sparse warnings.
I agree.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2011-01-05 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 18:58 [PATCH 0/2] OMAP: TWL: sparse fixes Nishanth Menon
2011-01-03 18:58 ` [PATCH 1/2] OMAP2+: TWL: make conversion routines static Nishanth Menon
2011-01-03 18:58 ` [PATCH 2/2] OMAP2+: TWL: include pm header for init protos Nishanth Menon
2011-01-03 22:36 ` [PATCH 0/2] OMAP: TWL: sparse fixes Russell King - ARM Linux
2011-01-03 22:39 ` Nishanth Menon
2011-01-04 20:37 ` Nishanth Menon
2011-01-05 0:25 ` Russell King - ARM Linux
2011-01-05 13:32 ` Nishanth Menon [this message]
2011-01-04 18:00 ` Kevin Hilman
2011-01-04 22:44 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24730A.3050905@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).