From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: twd_smp: add clock api support
Date: Wed, 12 Jan 2011 15:28:14 -0600 [thread overview]
Message-ID: <4D2E1CEE.5040900@gmail.com> (raw)
In-Reply-To: <20101221134515.GB1556@n2100.arm.linux.org.uk>
Russell,
On 12/21/2010 07:45 AM, Russell King - ARM Linux wrote:
> On Sat, Oct 02, 2010 at 09:34:46AM -0500, Rob Herring wrote:
>> From: Rob Herring<rob.herring@smooth-stone.com>
>>
>> The private timer freq is currently dynamically detected
>> using jiffies count to determine the rate. This method adds
>> a delay to boot-up, so use the clock api instead to get the
>> clock rate.
> More or less the same comments go for this as well as the timer-sp code.
I've implemented your requested changes for timer-sp code. The problem
with doing the same thing with smp_twd timer is I don't know what the
frequency of the timer is on various platforms or an understanding of
what their clock trees look like to do a proper implementation of the
clocks. I could make calling twd_timer_init mandatory and replace direct
setting of twd_base, but it would still fall back to calculating the
rate if no clock found. These are the current users:
mach-omap2/timer-gp.c
mach-realview/realview_eb.c
mach-realview/realview_pb11mp.c
mach-realview/realview_pbx.c
mach-s5pv310/time.c
mach-shmobile/smp-sh73a0.c
mach-tegra/timer.c
mach-ux500/cpu.c
mach-vexpress/ct-ca9x4.c
Rob
prev parent reply other threads:[~2011-01-12 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 14:34 [PATCH v2 0/3] ARM: add clock api to sp804 and smp_twd timers Rob Herring
2010-10-02 14:34 ` [PATCH v2 1/3] ARM: move timer-sp.c from versatile to common Rob Herring
2010-10-02 14:34 ` [PATCH v2 2/3] ARM: timer-sp: support timer clock freq other than 1MHz Rob Herring
2010-12-21 13:44 ` Russell King - ARM Linux
2010-12-21 14:14 ` Rob Herring
2010-10-02 14:34 ` [PATCH v2 3/3] ARM: twd_smp: add clock api support Rob Herring
2010-12-21 13:45 ` Russell King - ARM Linux
2011-01-12 21:28 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2E1CEE.5040900@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).