From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] unbreak ehci-mxc on otg port of i.MX27
Date: Thu, 13 Jan 2011 10:17:41 +0100 [thread overview]
Message-ID: <4D2EC335.4010300@eukrea.com> (raw)
In-Reply-To: <20110113091229.GE12078@pengutronix.de>
Hi Sascha,
On 13/01/2011 10:12, Sascha Hauer wrote:
>>
>> /* "dr" device has its own clock */
>> - if (pdev->id == 0) {
>> + if ((cpu_is_mx51())& (pdev->id == 0)) {
>
> should be&& and please remove the unnecessary braces around
> cpu_is_mx51(). Otherwise ok.
>
shame on me for the &, a wrong copy and paste from my working tree removed the
second one, While I'm here does MX53 or MX50 need this ?
Eric
next prev parent reply other threads:[~2011-01-13 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 9:06 [PATCH] unbreak ehci-mxc on otg port of i.MX27 Eric Bénard
2011-01-13 9:12 ` Sascha Hauer
2011-01-13 9:17 ` Eric Bénard [this message]
2011-01-13 13:53 ` [PATCH v2] " Eric Bénard
2011-01-13 17:48 ` Sergei Shtylyov
2011-01-13 18:02 ` Greg KH
2011-01-13 10:48 ` [PATCH] " Arnaud Patard (Rtp)
2011-01-13 12:17 ` Sergei Shtylyov
2011-01-13 12:22 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2EC335.4010300@eukrea.com \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).